From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/10251 Path: news.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: Issues when building libcxx libcxxabi with MUSL Date: Thu, 30 Jun 2016 09:45:18 -0400 Message-ID: <20160630134518.GB15995@brightrain.aerifal.cx> References: <87e30e04-a81d-4302-5dd7-0846aa0f711b@codeaurora.org> <1165D9B8-DEDB-4393-B734-3FC1AFFAB46F@gmail.com> <20160622194149.GU10893@brightrain.aerifal.cx> <8836ED26-349A-4701-9D7A-F1D2CF272A24@gmail.com> <20160630131546.GC19691@port70.net> <20160630133840.GD19691@port70.net> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1467294384 18406 80.91.229.3 (30 Jun 2016 13:46:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 30 Jun 2016 13:46:24 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-10264-gllmg-musl=m.gmane.org@lists.openwall.com Thu Jun 30 15:46:19 2016 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1bIcIB-0004Wy-Vq for gllmg-musl@m.gmane.org; Thu, 30 Jun 2016 15:46:08 +0200 Original-Received: (qmail 1699 invoked by uid 550); 30 Jun 2016 13:45:32 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 1631 invoked from network); 30 Jun 2016 13:45:31 -0000 Content-Disposition: inline In-Reply-To: <20160630133840.GD19691@port70.net> User-Agent: Mutt/1.5.21 (2010-09-15) Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:10251 Archived-At: On Thu, Jun 30, 2016 at 03:38:40PM +0200, Szabolcs Nagy wrote: > * Szabolcs Nagy [2016-06-30 15:15:47 +0200]: > > * Julien Ramseier [2016-06-30 14:50:14 +0200]: > > > A workaround for the C++11 constexpr issue should land soon in libcxx trunk. > > > http://reviews.llvm.org/D21637 > > > > > > > note that without pthread_mutex_destroy it may leak resources. > > > > sorry libc++ uses pthread_mutex_destroy correctly > (the ~mutex() definition is just in another file). > > there is still a nasty conformance issue that affects > all c++ library implementations: the mutex and thread > headers include They could at least reduce the dependency to sys/types.h with almost no changes, I think. Better would be including just a proper-sized buffer and initializing the mutex into it via code in its own TU, not a public header file. > it is not valid to include a posix header in c++ code, > this pollutes the global namespace, might not have valid > c++ syntax (posix headers are c99) and more importantly > pthread types are visible through native_handle() which > makes this impossible to fix. That can be fixed just by removing them (existence of native handles is optional). Rich