From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: Re: [PATCH v2] Add stdc-predef.h.
Date: Sun, 3 Jul 2016 20:16:41 -0400 [thread overview]
Message-ID: <20160704001641.GM15995@brightrain.aerifal.cx> (raw)
In-Reply-To: <CAA-4+jfV29L73vzvLAXSW_mhe6iud+7i0F1bH+fuvyWS9UT1vw@mail.gmail.com>
On Wed, Jun 08, 2016 at 11:57:02PM +0900, Masanori Ogino wrote:
> 2016-06-04 14:04 GMT+09:00 Rich Felker <dalias@libc.org>:
> > On Sat, Jun 04, 2016 at 01:19:47PM +0900, Masanori Ogino wrote:
> >> > #define __STDC_ISO_10646__ 201103L
> >> > #define __STDC_UTF_16__ 1
> >> > #define __STDC_UTF_32__ 1
> >> > #define __STDC_IEC_559__ 1
> >> > #define __STDC_NO_ATOMICS__ 1
> >> >
> >> > #endif
> >> >
> >> > Obviously my Unicode date is older -- I haven't checked which is more
> >> > correct, but after the next release we should update to latest Unicode
> >> > anyway.
> >>
> >> Sure.
> >>
> >> By the way, is there any automation script to update them using the
> >> Unicode database? I couldn't find that.
> >
> > There's an unpolished set of tools that do the job, which I posted the
> > the mailing list several years back. I should publish them in a more
> > permanent and accessible place though.
> >
> > Also the tools are not entirely sufficient to perform an upgrade.
> > Adding new case mappings requires some manual work, checking for case
> > mappings in Unicode that musl doesn't produce and adding the right
> > table tricks to get them.
>
> OK.
>
> >> > #if !defined(__GCC_IEC_559) || __GCC_IEC_559 > 0
> >> > #define __STDC_IEC_559__ 1
> >> > #endif
> >> >
> >> > What do you think? Anyone else have thoughts on the matter?
> >> >
> >>
> >> Well, is there any compiler that does not define __GCC_IEC_559 but
> >> uses stdc-predef.h?
> >
> > Even old (pre-4.8) gcc doesn't use stdc-predef.h, but you can add
> > "-include stdc-predef.h" to its specs file. Presumably you can do
> > similar tricks with other compilers (via a wrapper script if nothing
> > else).
>
> I see. I don't have any strong opinion against !defined(__GCC_IEC_559)
> clause and I'm happy with it. I guess that such users are wise enough
> to define the proper __GCC_IEC_559 value after reviewing the header,
> though.
>
> I'm sorry for the delay.
OK, commited patch based on this. Thanks!
Rich
next prev parent reply other threads:[~2016-07-04 0:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-05 2:23 Masanori Ogino
2016-06-01 8:21 ` Masanori Ogino
2016-06-03 19:04 ` Rich Felker
2016-06-04 4:19 ` Masanori Ogino
2016-06-04 5:04 ` Rich Felker
2016-06-08 14:57 ` Masanori Ogino
2016-07-04 0:16 ` Rich Felker [this message]
2016-07-06 7:39 ` Masanori Ogino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160704001641.GM15995@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).