From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/10283 Path: news.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: Re: [PATCH v2] Add stdc-predef.h. Date: Sun, 3 Jul 2016 20:16:41 -0400 Message-ID: <20160704001641.GM15995@brightrain.aerifal.cx> References: <1459823023-5951-1-git-send-email-masanori.ogino@gmail.com> <20160603190453.GP10893@brightrain.aerifal.cx> <20160604050402.GQ10893@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1467591423 2942 80.91.229.3 (4 Jul 2016 00:17:03 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 4 Jul 2016 00:17:03 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-10296-gllmg-musl=m.gmane.org@lists.openwall.com Mon Jul 04 02:17:03 2016 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1bJrZJ-0005iW-S9 for gllmg-musl@m.gmane.org; Mon, 04 Jul 2016 02:16:57 +0200 Original-Received: (qmail 26277 invoked by uid 550); 4 Jul 2016 00:16:55 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 26259 invoked from network); 4 Jul 2016 00:16:54 -0000 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:10283 Archived-At: On Wed, Jun 08, 2016 at 11:57:02PM +0900, Masanori Ogino wrote: > 2016-06-04 14:04 GMT+09:00 Rich Felker : > > On Sat, Jun 04, 2016 at 01:19:47PM +0900, Masanori Ogino wrote: > >> > #define __STDC_ISO_10646__ 201103L > >> > #define __STDC_UTF_16__ 1 > >> > #define __STDC_UTF_32__ 1 > >> > #define __STDC_IEC_559__ 1 > >> > #define __STDC_NO_ATOMICS__ 1 > >> > > >> > #endif > >> > > >> > Obviously my Unicode date is older -- I haven't checked which is more > >> > correct, but after the next release we should update to latest Unicode > >> > anyway. > >> > >> Sure. > >> > >> By the way, is there any automation script to update them using the > >> Unicode database? I couldn't find that. > > > > There's an unpolished set of tools that do the job, which I posted the > > the mailing list several years back. I should publish them in a more > > permanent and accessible place though. > > > > Also the tools are not entirely sufficient to perform an upgrade. > > Adding new case mappings requires some manual work, checking for case > > mappings in Unicode that musl doesn't produce and adding the right > > table tricks to get them. > > OK. > > >> > #if !defined(__GCC_IEC_559) || __GCC_IEC_559 > 0 > >> > #define __STDC_IEC_559__ 1 > >> > #endif > >> > > >> > What do you think? Anyone else have thoughts on the matter? > >> > > >> > >> Well, is there any compiler that does not define __GCC_IEC_559 but > >> uses stdc-predef.h? > > > > Even old (pre-4.8) gcc doesn't use stdc-predef.h, but you can add > > "-include stdc-predef.h" to its specs file. Presumably you can do > > similar tricks with other compilers (via a wrapper script if nothing > > else). > > I see. I don't have any strong opinion against !defined(__GCC_IEC_559) > clause and I'm happy with it. I guess that such users are wise enough > to define the proper __GCC_IEC_559 value after reviewing the header, > though. > > I'm sorry for the delay. OK, commited patch based on this. Thanks! Rich