From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: build musl for armv7m
Date: Tue, 5 Jul 2016 16:08:47 -0400 [thread overview]
Message-ID: <20160705200847.GV15995@brightrain.aerifal.cx> (raw)
In-Reply-To: <ab5fb134-1fb0-4fbe-d281-b3aeea55bb9c@codeaurora.org>
On Wed, Jun 22, 2016 at 05:21:54PM -0700, Zhao, Weiming wrote:
> diff --git a/src/string/arm/memcpy_le.S b/src/string/arm/memcpy_le.S
> index 4db4844..df9f5c8 100644
> --- a/src/string/arm/memcpy_le.S
> +++ b/src/string/arm/memcpy_le.S
> @@ -241,7 +241,12 @@ non_congruent:
> beq 2f
> ldr r5, [r1], #4
> sub r2, r2, #4
> +#if !defined(__thumb2__) || (__ARM_ARCH_7A__ || __ARM_ARCH_7R__ || __ARM_ARCH > 7)
> orr r4, r3, r5, lsl lr
> +#else
> + lsl r4, r5, lr
> + orr r4, r3, r4
> +#endif
I don't see how this new logic makes sense at all. The goal is to use
the less-efficient code for the case where you're building as thumb
and thumb2 is not supported (i.e. limited to thumb1). That would be:
#if defined(__thumb2__) || !defined(__thumb__)
orr r4, r3, r5, lsl lr
#else
lsl r4, r5, lr
orr r4, r3, r4
#endif
Does that look right?
I'm trying to wrap up the 1.1.15 release right now so I don't think
these changes will make it in, but I want to finish addressing _all_
of the thumb/cortex-m compat issues soon, hopefully in the next
release cycle. Let's start a new thread figuring out what's still
needed.
Rich
next prev parent reply other threads:[~2016-07-05 20:08 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-14 8:49 weimingz
2016-06-14 13:00 ` Rich Felker
2016-06-14 16:12 ` Zhao, Weiming
2016-06-14 16:32 ` Szabolcs Nagy
2016-06-14 16:58 ` Zhao, Weiming
2016-06-14 17:40 ` Zhao, Weiming
2016-06-16 18:34 ` Zhao, Weiming
2016-06-20 19:58 ` Rich Felker
2016-06-22 19:08 ` Zhao, Weiming
2016-06-22 19:19 ` Rich Felker
2016-06-22 20:37 ` Zhao, Weiming
2016-06-22 23:26 ` Rich Felker
2016-06-23 0:21 ` Zhao, Weiming
2016-06-23 4:22 ` Rich Felker
2016-06-23 6:04 ` weimingz
2016-06-23 9:57 ` Szabolcs Nagy
2016-06-23 14:22 ` weimingz
2016-07-05 20:08 ` Rich Felker [this message]
2016-06-20 17:17 ` Zhao, Weiming
2016-06-14 14:38 ` Rich Felker
2016-06-14 16:35 ` Zhao, Weiming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160705200847.GV15995@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).