* MIPS regression in 1.1.15, patch here
@ 2016-07-13 19:10 Rich Felker
2016-07-13 19:24 ` Rich Felker
0 siblings, 1 reply; 2+ messages in thread
From: Rich Felker @ 2016-07-13 19:10 UTC (permalink / raw)
To: musl
All users of mips targets should apply this patch. I'll probably make
a fixup release soon since having wrong values in the headers is a big
problem that will lead to broken binaries in the wild.
https://git.musl-libc.org/cgit/musl/commit/?id=cff5747c74c41b22f1ce1340978b1c226a8cdf32
Sorry for the mistake -- I wrongly thought the changes were fixing
something that was broken in practice.
Rich
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: MIPS regression in 1.1.15, patch here
2016-07-13 19:10 MIPS regression in 1.1.15, patch here Rich Felker
@ 2016-07-13 19:24 ` Rich Felker
0 siblings, 0 replies; 2+ messages in thread
From: Rich Felker @ 2016-07-13 19:24 UTC (permalink / raw)
To: musl
[-- Attachment #1: Type: text/plain, Size: 587 bytes --]
On Wed, Jul 13, 2016 at 03:10:36PM -0400, Rich Felker wrote:
> All users of mips targets should apply this patch. I'll probably make
> a fixup release soon since having wrong values in the headers is a big
> problem that will lead to broken binaries in the wild.
>
> https://git.musl-libc.org/cgit/musl/commit/?id=cff5747c74c41b22f1ce1340978b1c226a8cdf32
>
> Sorry for the mistake -- I wrongly thought the changes were fixing
> something that was broken in practice.
An unrelated change slipped into there which I've now fixed in a
second commit. The correct patch is attached.
Rich
[-- Attachment #2: mips-regression.diff --]
[-- Type: text/plain, Size: 1382 bytes --]
diff --git a/arch/mips/bits/termios.h b/arch/mips/bits/termios.h
index f559f76..6a1205d 100644
--- a/arch/mips/bits/termios.h
+++ b/arch/mips/bits/termios.h
@@ -141,9 +141,9 @@ struct termios {
#define TCOFLUSH 1
#define TCIOFLUSH 2
-#define TCSANOW 0x540e
-#define TCSADRAIN 0x540f
-#define TCSAFLUSH 0x5410
+#define TCSANOW 0
+#define TCSADRAIN 1
+#define TCSAFLUSH 2
#if defined(_GNU_SOURCE) || defined(_BSD_SOURCE)
#define EXTA 0000016
diff --git a/arch/mips64/bits/termios.h b/arch/mips64/bits/termios.h
index f559f76..6a1205d 100644
--- a/arch/mips64/bits/termios.h
+++ b/arch/mips64/bits/termios.h
@@ -141,9 +141,9 @@ struct termios {
#define TCOFLUSH 1
#define TCIOFLUSH 2
-#define TCSANOW 0x540e
-#define TCSADRAIN 0x540f
-#define TCSAFLUSH 0x5410
+#define TCSANOW 0
+#define TCSADRAIN 1
+#define TCSAFLUSH 2
#if defined(_GNU_SOURCE) || defined(_BSD_SOURCE)
#define EXTA 0000016
diff --git a/arch/mipsn32/bits/termios.h b/arch/mipsn32/bits/termios.h
index f559f76..6a1205d 100644
--- a/arch/mipsn32/bits/termios.h
+++ b/arch/mipsn32/bits/termios.h
@@ -141,9 +141,9 @@ struct termios {
#define TCOFLUSH 1
#define TCIOFLUSH 2
-#define TCSANOW 0x540e
-#define TCSADRAIN 0x540f
-#define TCSAFLUSH 0x5410
+#define TCSANOW 0
+#define TCSADRAIN 1
+#define TCSAFLUSH 2
#if defined(_GNU_SOURCE) || defined(_BSD_SOURCE)
#define EXTA 0000016
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-07-13 19:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-13 19:10 MIPS regression in 1.1.15, patch here Rich Felker
2016-07-13 19:24 ` Rich Felker
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).