From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/10315 Path: news.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: MIPS regression in 1.1.15, patch here Date: Wed, 13 Jul 2016 15:24:46 -0400 Message-ID: <20160713192446.GK15995@brightrain.aerifal.cx> References: <20160713191036.GJ15995@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="rJwd6BRFiFCcLxzm" X-Trace: ger.gmane.org 1468437906 8652 80.91.229.3 (13 Jul 2016 19:25:06 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 13 Jul 2016 19:25:06 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-10328-gllmg-musl=m.gmane.org@lists.openwall.com Wed Jul 13 21:25:04 2016 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1bNPmI-0003U4-IY for gllmg-musl@m.gmane.org; Wed, 13 Jul 2016 21:25:02 +0200 Original-Received: (qmail 22102 invoked by uid 550); 13 Jul 2016 19:25:00 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 22075 invoked from network); 13 Jul 2016 19:24:59 -0000 Content-Disposition: inline In-Reply-To: <20160713191036.GJ15995@brightrain.aerifal.cx> User-Agent: Mutt/1.5.21 (2010-09-15) Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:10315 Archived-At: --rJwd6BRFiFCcLxzm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jul 13, 2016 at 03:10:36PM -0400, Rich Felker wrote: > All users of mips targets should apply this patch. I'll probably make > a fixup release soon since having wrong values in the headers is a big > problem that will lead to broken binaries in the wild. > > https://git.musl-libc.org/cgit/musl/commit/?id=cff5747c74c41b22f1ce1340978b1c226a8cdf32 > > Sorry for the mistake -- I wrongly thought the changes were fixing > something that was broken in practice. An unrelated change slipped into there which I've now fixed in a second commit. The correct patch is attached. Rich --rJwd6BRFiFCcLxzm Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="mips-regression.diff" diff --git a/arch/mips/bits/termios.h b/arch/mips/bits/termios.h index f559f76..6a1205d 100644 --- a/arch/mips/bits/termios.h +++ b/arch/mips/bits/termios.h @@ -141,9 +141,9 @@ struct termios { #define TCOFLUSH 1 #define TCIOFLUSH 2 -#define TCSANOW 0x540e -#define TCSADRAIN 0x540f -#define TCSAFLUSH 0x5410 +#define TCSANOW 0 +#define TCSADRAIN 1 +#define TCSAFLUSH 2 #if defined(_GNU_SOURCE) || defined(_BSD_SOURCE) #define EXTA 0000016 diff --git a/arch/mips64/bits/termios.h b/arch/mips64/bits/termios.h index f559f76..6a1205d 100644 --- a/arch/mips64/bits/termios.h +++ b/arch/mips64/bits/termios.h @@ -141,9 +141,9 @@ struct termios { #define TCOFLUSH 1 #define TCIOFLUSH 2 -#define TCSANOW 0x540e -#define TCSADRAIN 0x540f -#define TCSAFLUSH 0x5410 +#define TCSANOW 0 +#define TCSADRAIN 1 +#define TCSAFLUSH 2 #if defined(_GNU_SOURCE) || defined(_BSD_SOURCE) #define EXTA 0000016 diff --git a/arch/mipsn32/bits/termios.h b/arch/mipsn32/bits/termios.h index f559f76..6a1205d 100644 --- a/arch/mipsn32/bits/termios.h +++ b/arch/mipsn32/bits/termios.h @@ -141,9 +141,9 @@ struct termios { #define TCOFLUSH 1 #define TCIOFLUSH 2 -#define TCSANOW 0x540e -#define TCSADRAIN 0x540f -#define TCSAFLUSH 0x5410 +#define TCSANOW 0 +#define TCSADRAIN 1 +#define TCSAFLUSH 2 #if defined(_GNU_SOURCE) || defined(_BSD_SOURCE) #define EXTA 0000016 --rJwd6BRFiFCcLxzm--