From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: musl@lists.openwall.com
Subject: utmp symbol conflict
Date: Thu, 4 Aug 2016 22:28:52 +0200 [thread overview]
Message-ID: <20160804222852.6fbec1a6@free-electrons.com> (raw)
Hello,
The shellinabox project
(https://github.com/shellinabox/shellinabox) fails to build with musl
due to the following define in musl's utmp.h:
#define utmp utmpx
Indeed shellinabox/launcher.c has the following piece of code
(https://github.com/shellinabox/shellinabox/blob/master/shellinabox/launcher.c#L1572) :
struct utmpx utmpx = utmp->utmpx;
if (service->useLogin || service->authUser) {
utmpx.ut_type = LOGIN_PROCESS;
memset(utmpx.ut_host, 0, sizeof(utmpx.ut_host));
}
Where "utmp" is of type "struct Utmp *", which is an internal structure
type defined as:
struct Utmp {
const char pid[32];
int pty;
int useLogin;
#ifdef HAVE_UTMPX_H
struct utmpx utmpx;
#endif
};
Unfortunately, with musl's definition #define utmp utmpx, the line:
struct utmpx utmpx = utmp->utmpx;
gets turned after pre-processing to:
struct utmpx utmpx = utmpx->utmpx;
which obviously causes a build failure:
shellinabox/launcher.c: In function ‘childProcess’:
shellinabox/launcher.c:1576:41: error: invalid type argument of ‘->’ (have ‘struct utmpx’)
struct utmpx utmpx = utmp->utmpx;
^
I don't think the symbol "utmp" as a variable name is reserved, so is
the #define utmp utmpx done by musl really a legal thing to do?
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next reply other threads:[~2016-08-04 20:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-04 20:28 Thomas Petazzoni [this message]
2016-08-04 22:20 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160804222852.6fbec1a6@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).