From: Olivier Brunel <jjk@jjacky.com>
To: musl@lists.openwall.com
Subject: Re: [PATCH] getdtablesize: Fix returning hard instead of soft rlimit
Date: Sat, 13 Aug 2016 21:36:13 +0200 [thread overview]
Message-ID: <20160813213613.3e5c068c@jjacky.com> (raw)
In-Reply-To: <20160813192501.GE15995@brightrain.aerifal.cx>
On Sat, 13 Aug 2016 15:25:02 -0400
Rich Felker <dalias@libc.org> wrote:
> On Sat, Aug 13, 2016 at 08:31:49PM +0200, Olivier Brunel wrote:
> > ---
> > src/legacy/getdtablesize.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/legacy/getdtablesize.c b/src/legacy/getdtablesize.c
> > index 682da6d..b30c193 100644
> > --- a/src/legacy/getdtablesize.c
> > +++ b/src/legacy/getdtablesize.c
> > @@ -7,5 +7,5 @@ int getdtablesize(void)
> > {
> > struct rlimit rl;
> > getrlimit(RLIMIT_NOFILE, &rl);
> > - return rl.rlim_max < INT_MAX ? rl.rlim_max : INT_MAX;
> > + return rl.rlim_cur < INT_MAX ? rl.rlim_cur : INT_MAX;
>
> Is there a motivation for this?
>
> Rich
Well, I found this running tests for findutils, and having a couple
failing because of it. I'm not sure about possible
implications/issues it could cause in the actual tools, was only trying
to get the tests to pass (and things to work as expected), but I
wasn't facing an "actual" issue/bug, if that was the question.
next prev parent reply other threads:[~2016-08-13 19:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-13 18:31 Olivier Brunel
2016-08-13 19:25 ` Rich Felker
2016-08-13 19:36 ` Olivier Brunel [this message]
2016-08-15 15:33 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160813213613.3e5c068c@jjacky.com \
--to=jjk@jjacky.com \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).