mailing list of musl libc
 help / color / mirror / code / Atom feed
* [PATCH] fix FFSYNC by changing it to O_SYNC
@ 2016-08-18 15:06 Duncan Overbruck
  2016-08-30 21:20 ` Rich Felker
  0 siblings, 1 reply; 2+ messages in thread
From: Duncan Overbruck @ 2016-08-18 15:06 UTC (permalink / raw)
  To: musl

O_FSYNC was never defined and is legacy/wrong, nothing seems to use it.
---
 include/fcntl.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/fcntl.h b/include/fcntl.h
index e683e4d..0e165ca 100644
--- a/include/fcntl.h
+++ b/include/fcntl.h
@@ -99,7 +99,7 @@ int posix_fallocate(int, off_t, off_t);
 #define AT_EMPTY_PATH 0x1000
 
 #define FAPPEND O_APPEND
-#define FFSYNC O_FSYNC
+#define FFSYNC O_SYNC
 #define FASYNC O_ASYNC
 #define FNONBLOCK O_NONBLOCK
 #define FNDELAY O_NDELAY
-- 
2.9.3



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] fix FFSYNC by changing it to O_SYNC
  2016-08-18 15:06 [PATCH] fix FFSYNC by changing it to O_SYNC Duncan Overbruck
@ 2016-08-30 21:20 ` Rich Felker
  0 siblings, 0 replies; 2+ messages in thread
From: Rich Felker @ 2016-08-30 21:20 UTC (permalink / raw)
  To: musl

On Thu, Aug 18, 2016 at 05:06:16PM +0200, Duncan Overbruck wrote:
> O_FSYNC was never defined and is legacy/wrong, nothing seems to use it.
> ---
>  include/fcntl.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/fcntl.h b/include/fcntl.h
> index e683e4d..0e165ca 100644
> --- a/include/fcntl.h
> +++ b/include/fcntl.h
> @@ -99,7 +99,7 @@ int posix_fallocate(int, off_t, off_t);
>  #define AT_EMPTY_PATH 0x1000
>  
>  #define FAPPEND O_APPEND
> -#define FFSYNC O_FSYNC
> +#define FFSYNC O_SYNC
>  #define FASYNC O_ASYNC
>  #define FNONBLOCK O_NONBLOCK
>  #define FNDELAY O_NDELAY

Thanks! Committing.

Rich


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-08-30 21:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-18 15:06 [PATCH] fix FFSYNC by changing it to O_SYNC Duncan Overbruck
2016-08-30 21:20 ` Rich Felker

Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).