From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: [PATCH][RFC] fix strtod int optimization in non-nearest rounding mode
Date: Fri, 9 Sep 2016 19:55:14 -0400 [thread overview]
Message-ID: <20160909235514.GU15995@brightrain.aerifal.cx> (raw)
In-Reply-To: <20160904025102.GN1280@port70.net>
On Sun, Sep 04, 2016 at 04:51:03AM +0200, Szabolcs Nagy wrote:
> the mid-sized integer optimization relies on lnz set up properly
> to mark the last non-zero decimal digit, but this was not done
> if the non-zero digit lied outside the KMAX digits of the base
> 10^9 number representation.
>
> so if the fractional part was a very long list of zeros (>2048*9 on
> x86) followed by non-zero digits then the integer optimization could
> kick in discarding the tiny non-zero fraction which can mean wrong
> result on non-nearest rounding mode.
>
> strtof, strtod and strtold were all affected.
And *scanf. :-)
> ---
> the dc counter is long long, but lnz is int, so this is
> not correct on 64bit targets where dc can be >INT_MAX,
> probably lnz should be just set to KMAX*9 or similar in
> this case.
The issue is not exclusive to 64-bit targets. You can scanf a >2GB
decimal string on 32-bit too. We could just set lnz to match the
location where the |=1 takes place (on the order of KMAX*9), or we
could just make lnz long long (it's only used one other place). Your
approach is probably nicer though.
Rich
prev parent reply other threads:[~2016-09-09 23:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-04 2:51 Szabolcs Nagy
2016-09-09 23:55 ` Rich Felker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160909235514.GU15995@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).