From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/10438 Path: news.gmane.org!.POSTED!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: incompatibility between libtheora/mmx and musl ? Date: Tue, 13 Sep 2016 16:41:50 -0400 Message-ID: <20160913204149.GX15995@brightrain.aerifal.cx> References: <20160913180649.GN16436@example.net> <20160913192006.GB3703@voyager> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1473799338 8870 195.159.176.226 (13 Sep 2016 20:42:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 13 Sep 2016 20:42:18 +0000 (UTC) User-Agent: Mutt/1.5.21 (2010-09-15) To: musl@lists.openwall.com Original-X-From: musl-return-10451-gllmg-musl=m.gmane.org@lists.openwall.com Tue Sep 13 22:42:11 2016 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1bjuWq-0000tC-VO for gllmg-musl@m.gmane.org; Tue, 13 Sep 2016 22:42:05 +0200 Original-Received: (qmail 30409 invoked by uid 550); 13 Sep 2016 20:42:04 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 30386 invoked from network); 13 Sep 2016 20:42:03 -0000 Content-Disposition: inline In-Reply-To: <20160913192006.GB3703@voyager> Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:10438 Archived-At: On Tue, Sep 13, 2016 at 09:20:06PM +0200, Markus Wichmann wrote: > On Tue, Sep 13, 2016 at 08:06:49PM +0200, u-uy74@aetey.se wrote: > > https://trac.xiph.org/ticket/2287 > > Alright, I had a look at it. > > 1. The free() in the loader: That would be reclaim_gaps(). valgrind > really doesn't like it. > > 2. Uninitialized values in calloc: There is only one conditional in > calloc(), and it depends on the two parameters. Is it possible that > those are uninitialized? I think this is also a false positive -- valgrind treats calloc as a normal consumer of malloc rather than part of the malloc implementation and thus does not like the conditional zeroing: for (z=p; n; n--, z++) if (*z) *z=0; Rich