From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: incompatibility between libtheora/mmx and musl ?
Date: Wed, 14 Sep 2016 10:39:42 -0400 [thread overview]
Message-ID: <20160914143941.GA15995@brightrain.aerifal.cx> (raw)
In-Reply-To: <20160914173138.034eab55@vostro>
On Wed, Sep 14, 2016 at 05:31:37PM +0300, Timo Teras wrote:
> On Wed, 14 Sep 2016 10:28:42 -0400
> Rich Felker <dalias@libc.org> wrote:
>
> > > > there can be some call abi issue (register clobbering,
> > > > stack alignment,..) because of the asm, but that's hard
> > > > to check.
> > >
> > > Is musl in any way special compared to glibc/uclibc in its register
> > > usage?
> >
> > Not in principle; this is mandated by the ABI. But it's possible that
> > their violation of ABI contracts is visible with some implementations
> > but not others. For example if they're calling malloc from code that's
> > using asm it's possible that they assume the floating point registers
> > (or mmx state) are call-saved rather than call-clobbered. This is an
> > invalid assumption that might happen to actively break on musl but not
> > glibc. IIRC you need some special instructions to switch between x87
> > and (original) mmx usage; perhaps they're missing this somewhere.
>
> Also, since it's Alpine (mentioned in first there with the bug report),
> we compile everything PIE. So on x86 ebx is reserved and should not be
> clobbered.
ebx is always a call-saved register in the x86 ABI, though. The
difference is that, if they make any cross-library calls that may go
through the PLT, ebx must point to the caller's GOT at the time of the
call. But this difference only applies in the main-program (for
static-linked libtheora, for instance); with dynamic linking the code
is already required to be PIC and thus already has to be taking this
into account.
Rich
next prev parent reply other threads:[~2016-09-14 14:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-13 18:06 u-uy74
2016-09-13 19:20 ` Markus Wichmann
2016-09-13 20:41 ` Rich Felker
2016-09-13 20:43 ` Rich Felker
2016-09-14 10:32 ` u-uy74
2016-09-14 11:24 ` Szabolcs Nagy
2016-09-14 14:04 ` u-uy74
2016-09-14 14:28 ` Rich Felker
2016-09-14 14:31 ` Timo Teras
2016-09-14 14:39 ` Rich Felker [this message]
2016-09-14 14:40 ` Rich Felker
2016-09-14 14:41 ` Szabolcs Nagy
2016-09-14 15:11 ` u-uy74
2016-10-02 10:59 ` "non-float" malloc (was: incompatibility between libtheora/mmx and musl) u-uy74
2016-10-02 11:17 ` u-uy74
2016-10-02 12:08 ` Szabolcs Nagy
2016-10-02 12:24 ` u-uy74
2016-10-02 13:24 ` u-uy74
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160914143941.GA15995@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).