From: Felix Janda <felix.janda@posteo.de>
To: musl@lists.openwall.com
Subject: Re: [PATCH RFC] add pthread_setname_np
Date: Thu, 15 Sep 2016 07:57:03 -0400 [thread overview]
Message-ID: <20160915115703.GA473@nyan> (raw)
In-Reply-To: <alpine.LNX.2.20.13.1609150928370.30232@monopod.intra.ispras.ru>
Alexander Monakov wrote:
> Hi,
>
> On Wed, 14 Sep 2016, Felix Janda wrote:
> > --- /dev/null
> > +++ b/src/thread/pthread_setname_np.c
> > @@ -0,0 +1,21 @@
> [...]
> > + snprintf(f, sizeof f, "/proc/self/task/%d/comm", thread->tid);
> > + if ((fd = open(f, O_WRONLY)) < 0) return errno;
> > + if (write(fd, name, len) < 0) status = errno;
>
>
> Is there a reason to do it this way rather than via prctl(PR_SET_NAME, ...)?
> If so, it should be mentioned in the commit message. (I think using prctl
> would be more appropriate)
pthread_setname_np() is more general than prctl(PR_SET_NAME, ...): It can
change the name of any thread, not just the calling one.
Felix
next prev parent reply other threads:[~2016-09-15 11:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-15 3:02 Felix Janda
2016-09-15 3:27 ` Rich Felker
2016-09-15 3:43 ` Felix Janda
2016-09-15 4:17 ` Rich Felker
2016-09-15 12:00 ` Felix Janda
2016-09-15 6:32 ` Alexander Monakov
2016-09-15 11:57 ` Felix Janda [this message]
2016-09-15 14:33 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160915115703.GA473@nyan \
--to=felix.janda@posteo.de \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).