Re: [PATCH RFC] add pthread_setname_np

[Rich Felker <dalias@libc.org>]

On Thu, Sep 15, 2016 at 07:57:03AM -0400, Felix Janda wrote:
> Alexander Monakov wrote:
> > Hi,
> > 
> > On Wed, 14 Sep 2016, Felix Janda wrote:
> > > --- /dev/null
> > > +++ b/src/thread/pthread_setname_np.c
> > > @@ -0,0 +1,21 @@
> > [...]
> > > +	snprintf(f, sizeof f, "/proc/self/task/%d/comm", thread->tid);
> > > +	if ((fd = open(f, O_WRONLY)) < 0) return errno;
> > > +	if (write(fd, name, len) < 0) status = errno;
> > 
> > Is there a reason to do it this way rather than via prctl(PR_SET_NAME, ...)?
> > If so, it should be mentioned in the commit message. (I think using prctl
> > would be more appropriate)
> 
> pthread_setname_np() is more general than prctl(PR_SET_NAME, ...): It can
> change the name of any thread, not just the calling one.

It might be nice to use prctl if thread==pthread_self(), just to avoid
dependency on /proc in this case. But I think that's a minor detail.
This is a non-critical feature anyway.

Rich