From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/10460 Path: news.gmane.org!.POSTED!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH RFC] add pthread_setname_np Date: Thu, 15 Sep 2016 10:33:50 -0400 Message-ID: <20160915143350.GG15995@brightrain.aerifal.cx> References: <20160915030216.GA4535@nyan> <20160915115703.GA473@nyan> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1473950061 31066 195.159.176.226 (15 Sep 2016 14:34:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 15 Sep 2016 14:34:21 +0000 (UTC) User-Agent: Mutt/1.5.21 (2010-09-15) To: musl@lists.openwall.com Original-X-From: musl-return-10473-gllmg-musl=m.gmane.org@lists.openwall.com Thu Sep 15 16:34:09 2016 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1bkXjn-0006EI-CH for gllmg-musl@m.gmane.org; Thu, 15 Sep 2016 16:34:03 +0200 Original-Received: (qmail 16058 invoked by uid 550); 15 Sep 2016 14:34:03 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 16040 invoked from network); 15 Sep 2016 14:34:03 -0000 Content-Disposition: inline In-Reply-To: <20160915115703.GA473@nyan> Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:10460 Archived-At: On Thu, Sep 15, 2016 at 07:57:03AM -0400, Felix Janda wrote: > Alexander Monakov wrote: > > Hi, > > > > On Wed, 14 Sep 2016, Felix Janda wrote: > > > --- /dev/null > > > +++ b/src/thread/pthread_setname_np.c > > > @@ -0,0 +1,21 @@ > > [...] > > > + snprintf(f, sizeof f, "/proc/self/task/%d/comm", thread->tid); > > > + if ((fd = open(f, O_WRONLY)) < 0) return errno; > > > + if (write(fd, name, len) < 0) status = errno; > > > > Is there a reason to do it this way rather than via prctl(PR_SET_NAME, ...)? > > If so, it should be mentioned in the commit message. (I think using prctl > > would be more appropriate) > > pthread_setname_np() is more general than prctl(PR_SET_NAME, ...): It can > change the name of any thread, not just the calling one. It might be nice to use prctl if thread==pthread_self(), just to avoid dependency on /proc in this case. But I think that's a minor detail. This is a non-critical feature anyway. Rich