mailing list of musl libc
 help / color / mirror / code / Atom feed
* [PATCH v2] fix ifru_data and ifcu_buf types in net/if.h
@ 2016-09-16 17:34 Daniel Sabogal
  2016-09-16 22:00 ` Rich Felker
  0 siblings, 1 reply; 2+ messages in thread
From: Daniel Sabogal @ 2016-09-16 17:34 UTC (permalink / raw)
  To: musl

From: Daniel Sabogal <dsabogalcc@gmail.com>

glibc, freebsd, and openbsd use character pointers (caddr_t) for
these fields. only linux uses void pointer for the ifru_data type.
---
 include/net/if.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/net/if.h b/include/net/if.h
index 1a4059d..2f2fcc1 100644
--- a/include/net/if.h
+++ b/include/net/if.h
@@ -89,7 +89,7 @@ struct ifreq {
 		struct ifmap ifru_map;
 		char ifru_slave[IFNAMSIZ];
 		char ifru_newname[IFNAMSIZ];
-		void *ifru_data;
+		char *ifru_data;
 	} ifr_ifru;
 };
 
@@ -116,7 +116,7 @@ struct ifreq {
 struct ifconf {
 	int ifc_len;		
 	union {
-		void *ifcu_buf;
+		char *ifcu_buf;
 		struct ifreq *ifcu_req;
 	} ifc_ifcu;
 };
-- 
2.10.0



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] fix ifru_data and ifcu_buf types in net/if.h
  2016-09-16 17:34 [PATCH v2] fix ifru_data and ifcu_buf types in net/if.h Daniel Sabogal
@ 2016-09-16 22:00 ` Rich Felker
  0 siblings, 0 replies; 2+ messages in thread
From: Rich Felker @ 2016-09-16 22:00 UTC (permalink / raw)
  To: musl

On Fri, Sep 16, 2016 at 01:34:24PM -0400, Daniel Sabogal wrote:
> From: Daniel Sabogal <dsabogalcc@gmail.com>
> 
> glibc, freebsd, and openbsd use character pointers (caddr_t) for
> these fields. only linux uses void pointer for the ifru_data type.
> ---
>  include/net/if.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Thanks, applied.

Rich


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-09-16 22:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-16 17:34 [PATCH v2] fix ifru_data and ifcu_buf types in net/if.h Daniel Sabogal
2016-09-16 22:00 ` Rich Felker

Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).