From: Rich Felker <dalias@libc.org>
To: Daniel Sabogal <dsabogalcc@gmail.com>
Cc: musl@lists.openwall.com
Subject: Re: [PATCH v2] fix clock_nanosleep error case
Date: Sat, 17 Sep 2016 23:38:40 -0400 [thread overview]
Message-ID: <20160918033840.GZ15995@brightrain.aerifal.cx> (raw)
In-Reply-To: <20160917160545.4348-1-dsabogalcc@gmail.com>
On Sat, Sep 17, 2016 at 12:05:45PM -0400, Daniel Sabogal wrote:
> posix requires that EINVAL be returned if the first parameter specifies
> the cpu-time clock of the calling thread (CLOCK_THREAD_CPUTIME_ID).
> linux returns ENOTSUP instead so we handle this.
> ---
> Applied Szabolcs' suggestion for remapping the return value.
> clock_nanosleep is required to be a cancellation point.
> ---
> src/time/clock_nanosleep.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/src/time/clock_nanosleep.c b/src/time/clock_nanosleep.c
> index ec87b9e..9e4d9f1 100644
> --- a/src/time/clock_nanosleep.c
> +++ b/src/time/clock_nanosleep.c
> @@ -1,8 +1,10 @@
> #include <time.h>
> +#include <errno.h>
> #include "syscall.h"
> #include "libc.h"
>
> int clock_nanosleep(clockid_t clk, int flags, const struct timespec *req, struct timespec *rem)
> {
> - return -__syscall_cp(SYS_clock_nanosleep, clk, flags, req, rem);
> + int r = -__syscall_cp(SYS_clock_nanosleep, clk, flags, req, rem);
> + return clk == CLOCK_THREAD_CPUTIME_ID ? EINVAL : r;
> }
See:
On Sat, Sep 17, 2016 at 04:57:09PM +0200, Szabolcs Nagy wrote:
> you elide a cancellation point here.
>
> i think you should check and remap the return value instead.
"Remap the return value" would be more like:
return r==ENOTSUP ? EINVAL : r;
I don't know if it makes a big difference, but in principle it's
better to base conditions on a return value than an argument, since
basing them on an argument requires the value of that argument to be
preserved across the call and can thereby require spilling registers,
etc. I don't think that actually happens on any of the Linux syscall
ABIs but I'm not sure.
Rich
next prev parent reply other threads:[~2016-09-18 3:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-17 16:05 Daniel Sabogal
2016-09-18 3:38 ` Rich Felker [this message]
2016-09-18 19:01 ` Daniel Sabogal
2016-09-18 19:44 ` Szabolcs Nagy
2016-10-20 5:47 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160918033840.GZ15995@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=dsabogalcc@gmail.com \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).