mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: [PATCH] remove dead case in gethostbyname2_r
Date: Sat, 24 Sep 2016 01:11:03 -0400	[thread overview]
Message-ID: <20160924051103.GC19318@brightrain.aerifal.cx> (raw)
In-Reply-To: <20160924043806.31822-1-dsabogalcc@gmail.com>

On Sat, Sep 24, 2016 at 12:38:06AM -0400, Daniel Sabogal wrote:
> this case statement was accidently left behind when this function
> was refactored in commit e8f39ca4898237cf71657500f0b11534c47a0521.
> ---
> if (cnt<0) switch (cnt) {
> 	...
> 	case 0:
> 		break;
> }
> 
>  src/network/gethostbyname2_r.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/src/network/gethostbyname2_r.c b/src/network/gethostbyname2_r.c
> index 5c1cae9..fc89487 100644
> --- a/src/network/gethostbyname2_r.c
> +++ b/src/network/gethostbyname2_r.c
> @@ -34,8 +34,6 @@ int gethostbyname2_r(const char *name, int af,
>  	case EAI_SYSTEM:
>  		*err = NO_RECOVERY;
>  		return errno;
> -	case 0:
> -		break;
>  	}
>  
>  	h->h_addrtype = af;
> -- 
> 2.10.0

Thanks! Applied.

Rich


      reply	other threads:[~2016-09-24  5:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-24  4:38 Daniel Sabogal
2016-09-24  5:11 ` Rich Felker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160924051103.GC19318@brightrain.aerifal.cx \
    --to=dalias@libc.org \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).