mailing list of musl libc
 help / color / mirror / code / Atom feed
* [PATCH] remove dead case in gethostbyname2_r
@ 2016-09-24  4:38 Daniel Sabogal
  2016-09-24  5:11 ` Rich Felker
  0 siblings, 1 reply; 2+ messages in thread
From: Daniel Sabogal @ 2016-09-24  4:38 UTC (permalink / raw)
  To: musl

this case statement was accidently left behind when this function
was refactored in commit e8f39ca4898237cf71657500f0b11534c47a0521.
---
if (cnt<0) switch (cnt) {
	...
	case 0:
		break;
}

 src/network/gethostbyname2_r.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/network/gethostbyname2_r.c b/src/network/gethostbyname2_r.c
index 5c1cae9..fc89487 100644
--- a/src/network/gethostbyname2_r.c
+++ b/src/network/gethostbyname2_r.c
@@ -34,8 +34,6 @@ int gethostbyname2_r(const char *name, int af,
 	case EAI_SYSTEM:
 		*err = NO_RECOVERY;
 		return errno;
-	case 0:
-		break;
 	}
 
 	h->h_addrtype = af;
-- 
2.10.0



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] remove dead case in gethostbyname2_r
  2016-09-24  4:38 [PATCH] remove dead case in gethostbyname2_r Daniel Sabogal
@ 2016-09-24  5:11 ` Rich Felker
  0 siblings, 0 replies; 2+ messages in thread
From: Rich Felker @ 2016-09-24  5:11 UTC (permalink / raw)
  To: musl

On Sat, Sep 24, 2016 at 12:38:06AM -0400, Daniel Sabogal wrote:
> this case statement was accidently left behind when this function
> was refactored in commit e8f39ca4898237cf71657500f0b11534c47a0521.
> ---
> if (cnt<0) switch (cnt) {
> 	...
> 	case 0:
> 		break;
> }
> 
>  src/network/gethostbyname2_r.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/src/network/gethostbyname2_r.c b/src/network/gethostbyname2_r.c
> index 5c1cae9..fc89487 100644
> --- a/src/network/gethostbyname2_r.c
> +++ b/src/network/gethostbyname2_r.c
> @@ -34,8 +34,6 @@ int gethostbyname2_r(const char *name, int af,
>  	case EAI_SYSTEM:
>  		*err = NO_RECOVERY;
>  		return errno;
> -	case 0:
> -		break;
>  	}
>  
>  	h->h_addrtype = af;
> -- 
> 2.10.0

Thanks! Applied.

Rich


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-09-24  5:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-24  4:38 [PATCH] remove dead case in gethostbyname2_r Daniel Sabogal
2016-09-24  5:11 ` Rich Felker

Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).