From: Rich Felker <dalias@libc.org>
To: Julien Ramseier <j.ramseier@gmail.com>
Cc: musl@lists.openwall.com
Subject: Re: Regression: git no longer works with musl libc's regex impl
Date: Tue, 4 Oct 2016 13:36:40 -0400 [thread overview]
Message-ID: <20161004173640.GZ19318@brightrain.aerifal.cx> (raw)
In-Reply-To: <BA763149-B048-4146-A8CA-11EC9A510469@gmail.com>
On Tue, Oct 04, 2016 at 07:33:49PM +0200, Julien Ramseier wrote:
>
> > Le 4 oct. 2016 à 18:08, Johannes Schindelin <Johannes.Schindelin@gmx.de> a écrit :
> >
> > And lastly, the best alternative would be to teach musl about
> > REG_STARTEND, as it is rather useful a feature.
>
> I don't remember if I sent a patch for it and was rejected,
> but I patched my musl copy some time ago to support REG_STARTEND.
> The patch is quite small, since the original tre regex implementation
> already supports it.
>
> Let me know if there is any interest to include REG_STARTEND in musl.
I don't mind looking at it, but I suspect it's fairly costly (maybe
5-10% performance hit) on archs like x86 that are
register-constrained, since you fundamentally need to do extra
spills/reloads to check not only for null termination but also
byte-count limit in the inner loops. This is why I did not keep TRE's
regnexec when I pulled in the code to begin with.
Rich
next prev parent reply other threads:[~2016-10-04 17:36 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-04 15:08 Rich Felker
2016-10-04 15:27 ` Jeff King
2016-10-04 15:40 ` Rich Felker
2016-10-04 16:08 ` Johannes Schindelin
2016-10-04 16:11 ` Rich Felker
2016-10-04 17:16 ` Johannes Schindelin
2016-10-04 18:00 ` Ray Donnelly
2016-10-04 17:29 ` Kurt H Maier
2016-10-04 17:33 ` Julien Ramseier
2016-10-04 17:36 ` Rich Felker [this message]
2016-10-04 17:39 ` [musl] " Rich Felker
2016-10-05 11:17 ` Johannes Schindelin
2016-10-05 13:01 ` Szabolcs Nagy
2016-10-05 13:15 ` Rich Felker
2016-10-04 22:06 ` [musl] " James B
2016-10-04 22:33 ` Rich Felker
2016-10-04 22:48 ` [musl] " Junio C Hamano
2016-10-05 13:11 ` Jakub Narębski
2016-10-05 16:15 ` Rich Felker
2016-10-05 10:41 ` Johannes Schindelin
2016-10-05 11:59 ` [musl] " James B
2016-10-05 16:11 ` Jeff King
2016-10-05 16:27 ` Rich Felker
2016-10-06 10:44 ` Johannes Schindelin
2016-10-06 19:18 ` Ævar Arnfjörð Bjarmason
2016-10-06 19:23 ` Jeff King
2016-10-06 19:25 ` Rich Felker
2016-10-06 19:28 ` Jeff King
2016-10-06 22:42 ` Ramsay Jones
2016-10-07 11:30 ` Jakub Narębski
2016-10-04 16:01 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161004173640.GZ19318@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=j.ramseier@gmail.com \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).