From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/10563 Path: news.gmane.org!.POSTED!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: Regression: git no longer works with musl libc's regex impl Date: Tue, 4 Oct 2016 13:36:40 -0400 Message-ID: <20161004173640.GZ19318@brightrain.aerifal.cx> References: <20161004150848.GA7949@brightrain.aerifal.cx> <20161004152722.ex2nox43oj5ak4yi@sigill.intra.peff.net> <20161004154045.GT19318@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1475602637 19508 195.159.176.226 (4 Oct 2016 17:37:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 4 Oct 2016 17:37:17 +0000 (UTC) User-Agent: Mutt/1.5.21 (2010-09-15) Cc: musl@lists.openwall.com To: Julien Ramseier Original-X-From: musl-return-10576-gllmg-musl=m.gmane.org@lists.openwall.com Tue Oct 04 19:37:14 2016 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1brTeB-0002bR-Vz for gllmg-musl@m.gmane.org; Tue, 04 Oct 2016 19:36:56 +0200 Original-Received: (qmail 29820 invoked by uid 550); 4 Oct 2016 17:36:56 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 29799 invoked from network); 4 Oct 2016 17:36:55 -0000 Content-Disposition: inline In-Reply-To: Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:10563 Archived-At: On Tue, Oct 04, 2016 at 07:33:49PM +0200, Julien Ramseier wrote: > > > Le 4 oct. 2016 à 18:08, Johannes Schindelin a écrit : > > > > And lastly, the best alternative would be to teach musl about > > REG_STARTEND, as it is rather useful a feature. > > I don't remember if I sent a patch for it and was rejected, > but I patched my musl copy some time ago to support REG_STARTEND. > The patch is quite small, since the original tre regex implementation > already supports it. > > Let me know if there is any interest to include REG_STARTEND in musl. I don't mind looking at it, but I suspect it's fairly costly (maybe 5-10% performance hit) on archs like x86 that are register-constrained, since you fundamentally need to do extra spills/reloads to check not only for null termination but also byte-count limit in the inner loops. This is why I did not keep TRE's regnexec when I pulled in the code to begin with. Rich