From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: getopt_long_only
Date: Thu, 13 Oct 2016 14:40:19 -0400 [thread overview]
Message-ID: <20161013184019.GV19318@brightrain.aerifal.cx> (raw)
In-Reply-To: <CAFhhQJTNHWzQG6qvW9OcFQN7L1w=v=sE2=Upv1fN9KF=GYP1Tw@mail.gmail.com>
On Thu, Oct 13, 2016 at 01:43:28PM -0400, Daniel Sabogal wrote:
> On Thu, Oct 13, 2016 at 10:42 AM, Sidney Manning <sidneym@codeaurora.org> wrote:
> > I may have found an issue with this API. When a double hyphen is
> > encountered the API is supposed to return a -1 but I'm seeing a '?'.
> >
> > My reference is from the Solaris docs which say: "The special option "--"
> > can be used to delimit the end of the options; when it is encountered, -1 is
> > returned and "--" is skipped. I attached a test case to show the problem.
> >
> > I made the following change it will cause the code to punt to getopt when
> > just a "--" is found:
> > argv[optind][0] == '-'
> > argv[optind][1] == '-'
> > argv[optind][2] == NULL
> >
> > diff --git a/src/misc/getopt_long.c b/src/misc/getopt_long.c
> > index 480c001..9764f56 100644
> > --- a/src/misc/getopt_long.c
> > +++ b/src/misc/getopt_long.c
> > @@ -53,7 +53,7 @@ static int __getopt_long_core(int argc, char *const *argv,
> > con
> > {
> > optarg = 0;
> > if (longopts && argv[optind][0] == '-' &&
> > - ((longonly && argv[optind][1]) ||
> > + ((longonly && argv[optind][1]) &&
> > (argv[optind][1] == '-' && argv[optind][2])))
> > {
> > int colon =
> > optstring[optstring[0]=='+'||optstring[0]=='-']==':'
>
> This will break getopt_long() since the entire condition won't hold
> whenever !longonly.
>
> I think just changing the longonly case to the following is sufficient.
>
> (longonly && argv[optind][1] && argv[optind][1] != '-')
Yes, that looks like the correct fix.
Rich
next prev parent reply other threads:[~2016-10-13 18:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-13 14:42 getopt_long_only Sidney Manning
2016-10-13 17:43 ` getopt_long_only Daniel Sabogal
2016-10-13 18:40 ` Rich Felker [this message]
2016-10-20 5:54 ` getopt_long_only Rich Felker
2016-10-20 16:17 ` getopt_long_only Rich Felker
2016-10-13 18:03 getopt_long_only Sidney Manning
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161013184019.GV19318@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).