From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: [PATCH 1/7] fix preadv2 and pwritev2 syscall numbers on x32 for linux v4.8
Date: Fri, 14 Oct 2016 11:16:05 -0400 [thread overview]
Message-ID: <20161014151605.GZ19318@brightrain.aerifal.cx> (raw)
In-Reply-To: <20161014151359.GR28065@port70.net>
On Fri, Oct 14, 2016 at 05:13:59PM +0200, Szabolcs Nagy wrote:
> * Khem Raj <raj.khem@gmail.com> [2016-10-14 14:09:10 +0200]:
>
> > On Sun, Oct 9, 2016 at 6:58 PM, Szabolcs Nagy <nsz@port70.net> wrote:
> > > the numbers were wrong in musl, but they were also wrong in the kernel
> > > and got fixed in v4.8 commit 3ebfd81f7fb3e81a754e37283b7f38c62244641a
> >
> > what happens if we now build musl trunk with linux kernel 3.7 ?
> >
>
> on v3.7 a raw syscall(__NR_preadv2,..) should return -ENOSYS.
>
> these syscalls appeared in v4.6 (with wrong numbers: they overlap
> with existing x32 numbers), but by accident i added them using
> the x86_64 numbers to musl (most x32 syscalls are mapped to
> x86_64 numbers), which means there is no overlap in musl.
>
> with >=v4.6 kernel musl would try to use the x86_64 syscalls from
> x32 which is wrong and i don't know how that plays out in practice.
>
> this affects musl >=v1.1.15
>
> linux v4.8 fixed the numbers, so we should fix them too.
More accurately, it affects programs making raw syscalls using headers
from musl libc >=v1.1.15. musl itself does not use these syscalls at
all.
Rich
prev parent reply other threads:[~2016-10-14 15:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-09 16:58 Szabolcs Nagy
2016-10-14 12:09 ` Khem Raj
2016-10-14 15:04 ` Rich Felker
2016-10-14 15:13 ` Szabolcs Nagy
2016-10-14 15:16 ` Rich Felker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161014151605.GZ19318@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).