From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: [PATCH] fix float formatting of some exact halfway cases
Date: Thu, 20 Oct 2016 01:55:50 -0400 [thread overview]
Message-ID: <20161020055550.GP19318@brightrain.aerifal.cx> (raw)
In-Reply-To: <20161011224959.GO28065@port70.net>
On Wed, Oct 12, 2016 at 12:49:59AM +0200, Szabolcs Nagy wrote:
> in nearest rounding mode exact halfway cases were not following the
> round to even rule if the rounding happened at a base 1000000000 digit
> boundary of the internal representation and the previous digit was odd.
>
> e.g. printf("%.0f", 1.5) printed 1 instead of 2.
> ---
> src/stdio/vfprintf.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/stdio/vfprintf.c b/src/stdio/vfprintf.c
> index e439a07..ff65295 100644
> --- a/src/stdio/vfprintf.c
> +++ b/src/stdio/vfprintf.c
> @@ -343,7 +343,8 @@ static int fmt_fp(FILE *f, long double y, int w, int p, int fl, int t)
> if (x || d+1!=z) {
> long double round = 2/LDBL_EPSILON;
> long double small;
> - if (*d/i & 1) round += 2;
> + if ((*d/i & 1) || (i==1000000000 && d>a && (d[-1]&1)))
> + round += 2;
> if (x<i/2) small=0x0.8p0;
> else if (x==i/2 && d+1==z) small=0x1.0p0;
> else small=0x1.8p0;
> --
> 2.10.0
Thanks, committed.
Rich
prev parent reply other threads:[~2016-10-20 5:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-11 22:49 Szabolcs Nagy
2016-10-20 5:55 ` Rich Felker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161020055550.GP19318@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).