mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: musl's strptime does not support POSIX %U/%W
Date: Fri, 21 Oct 2016 13:34:27 -0400	[thread overview]
Message-ID: <20161021173427.GW19318@brightrain.aerifal.cx> (raw)
In-Reply-To: <20161021161822.GV19318@brightrain.aerifal.cx>

On Fri, Oct 21, 2016 at 12:18:22PM -0400, Rich Felker wrote:
> On Fri, Oct 21, 2016 at 11:00:35AM +0200, Raphael 'kena' Poss wrote:
> > Hi all,
> > 
> > we at CockroachDB would like to integrate strptime, but some of our
> > users on Alpine Linux discovered that musl's strptime doesn't live up to
> > expectations:
> > 
> > conv_test.go:58: strptime("2018 10 4", "%Y %W %w"): got
> > "2017-12-31T00:00:00Z", expected "2018-03-08T00:00:00Z"
> > conv_test.go:58: strptime("2018 10 4", "%Y %U %w"): got
> > "2017-12-31T00:00:00Z", expected "2018-03-15T00:00:00Z"
> > 
> > Indeed there's a FIXME in there:
> > https://git.musl-libc.org/cgit/musl/tree/src/time/strptime.c#n123
> > 
> > We've filed this internally as
> > https://github.com/cockroachdb/cockroach/issues/10130
> > 
> > As of this day this is the only known limitation that prevents
> > compatibility of CockroachDB with musl. If you have any suggestions /
> > input we'd be glad to receive them!
> 
> Indeed, somehow I thought this FIXME had been fixed a long time ago,
> but it seems it hasn't. I'll see if we can get it added soon.

Looking at this in more detail, I see why it wasn't done before:
there's no clear spec for what output these should produce. struct tm
does not contain a week-number field, so the result would have to be
encoded in other fields -- but which ones? tm_yday? strptime is not
specified to produce a full, consistent struct tm for all inputs,
because many formats may be incomplete and other combinations of
format and input may yield contradictory information.

I'd be really interested in seeing some analysis of this situation by
someone who's studied it and has a viable proposal other than just
"reverse engineer glibc and do whatever it does".

Rich


  reply	other threads:[~2016-10-21 17:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-21  9:00 Raphael 'kena' Poss
2016-10-21 16:18 ` Rich Felker
2016-10-21 17:34   ` Rich Felker [this message]
2016-10-21 18:16     ` Rich Felker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161021173427.GW19318@brightrain.aerifal.cx \
    --to=dalias@libc.org \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).