[PATCH] fix namespace pollution in <unistd.h> by linux specific syscalls

[PATCH] fix namespace pollution in <unistd.h> by linux specific syscalls

[Felix Janda]

The exposure of pipe2() breaks compilation for staden-io_lib.
---
 include/unistd.h   | 4 ++--
 src/unistd/pipe2.c | 1 +
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/include/unistd.h b/include/unistd.h
index 09190af..1085da6 100644
--- a/include/unistd.h
+++ b/include/unistd.h
@@ -33,12 +33,10 @@ extern "C" {
 #include <bits/alltypes.h>
 
 int pipe(int [2]);
-int pipe2(int [2], int);
 int close(int);
 int posix_close(int, int);
 int dup(int);
 int dup2(int, int);
-int dup3(int, int, int);
 off_t lseek(int, off_t, int);
 int fsync(int);
 int fdatasync(int);
@@ -188,6 +186,8 @@ char *get_current_dir_name(void);
 int syncfs(int);
 int euidaccess(const char *, int);
 int eaccess(const char *, int);
+int pipe2(int [2], int);
+int dup3(int, int, int);
 #endif
 
 #if defined(_LARGEFILE64_SOURCE) || defined(_GNU_SOURCE)
diff --git a/src/unistd/pipe2.c b/src/unistd/pipe2.c
index f24f74f..af628d3 100644
--- a/src/unistd/pipe2.c
+++ b/src/unistd/pipe2.c
@@ -1,3 +1,4 @@
+#define _GNU_SOURCE
 #include <unistd.h>
 #include <errno.h>
 #include <fcntl.h>
-- 
2.7.3

Re: [PATCH] fix namespace pollution in <unistd.h> by linux specific syscalls

[Szabolcs Nagy]

* Felix Janda <felix.janda@posteo.de> [2016-11-03 08:56:30 -0400]:
> The exposure of pipe2() breaks compilation for staden-io_lib.

i think they should fix it as pipe2 is scheduled for issue8 of posix.
http://austingroupbugs.net/view.php?id=411

(in principle musl should follow the rules of the requested posix
version, but that would be significant pain to maintain and verify)

Re: [PATCH] fix namespace pollution in <unistd.h> by linux specific syscalls

[Felix Janda]

Szabolcs Nagy wrote:
> * Felix Janda <felix.janda@posteo.de> [2016-11-03 08:56:30 -0400]:
> > The exposure of pipe2() breaks compilation for staden-io_lib.
> 
> i think they should fix it as pipe2 is scheduled for issue8 of posix.
> http://austingroupbugs.net/view.php?id=411

ok, thanks for remarking that. So I take back my patch and will report
the issue to them. (I don't know whether one should bother with hiding
dup3.)

Felix

Re: [PATCH] fix namespace pollution in <unistd.h> by linux specific syscalls

[Rich Felker]

On Thu, Nov 03, 2016 at 11:28:07AM -0400, Felix Janda wrote:
> Szabolcs Nagy wrote:
> > * Felix Janda <felix.janda@posteo.de> [2016-11-03 08:56:30 -0400]:
> > > The exposure of pipe2() breaks compilation for staden-io_lib.
> > 
> > i think they should fix it as pipe2 is scheduled for issue8 of posix.
> > http://austingroupbugs.net/view.php?id=411
> 
> ok, thanks for remarking that. So I take back my patch and will report
> the issue to them. (I don't know whether one should bother with hiding
> dup3.)

dup3 is also POSIX-future.

Rich

Re: [PATCH] fix namespace pollution in <unistd.h> by linux specific syscalls

[Felix Janda]

Rich Felker wrote:
> On Thu, Nov 03, 2016 at 11:28:07AM -0400, Felix Janda wrote:
> > Szabolcs Nagy wrote:
> > > * Felix Janda <felix.janda@posteo.de> [2016-11-03 08:56:30 -0400]:
> > > > The exposure of pipe2() breaks compilation for staden-io_lib.
> > > 
> > > i think they should fix it as pipe2 is scheduled for issue8 of posix.
> > > http://austingroupbugs.net/view.php?id=411
> > 
> > ok, thanks for remarking that. So I take back my patch and will report
> > the issue to them. (I don't know whether one should bother with hiding
> > dup3.)
> 
> dup3 is also POSIX-future.

ok.

Also, staden-io_lib has been fixed in newer versions.
Sorry for the noise.

Felix