From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: [PATCH] fix ldso reserved library name handling
Date: Mon, 7 Nov 2016 12:03:23 -0500 [thread overview]
Message-ID: <20161107170323.GE1555@brightrain.aerifal.cx> (raw)
In-Reply-To: <20161101014909.GF5749@port70.net>
On Tue, Nov 01, 2016 at 02:49:09AM +0100, Szabolcs Nagy wrote:
> If a DT_NEEDED entry was the prefix of a reserved library name
> (up to the first dot) then it was incorrectly treated as a libc
> reserved name.
>
> e.g. libp.so dependency was not loaded as it matched libpthread
> reserved name.
> ---
>
> this is not the smallest possible patch (most of the diff is
> indentation change), but i found the code cleaner without
> the z and l-3 computation.
>
> ldso/dynlink.c | 38 +++++++++++++++++++-------------------
> 1 file changed, 19 insertions(+), 19 deletions(-)
The existing code was obviously wrong and this seems to work with
simple testing (dlopen of reserved names still yields self pointer,
dlopen of nonexistent prefixes fails) so I'm committing it. Thanks.
Rich
prev parent reply other threads:[~2016-11-07 17:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-01 1:49 Szabolcs Nagy
2016-11-07 17:03 ` Rich Felker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161107170323.GE1555@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).