From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: [PATCH] s390: replace absolute branch with relative branch
Date: Mon, 28 Nov 2016 14:31:00 -0500 [thread overview]
Message-ID: <20161128193100.GX1555@brightrain.aerifal.cx> (raw)
In-Reply-To: <20161127181810.19519-1-koorogi@koorogi.info>
On Sun, Nov 27, 2016 at 12:18:10PM -0600, Bobby Bingham wrote:
> ---
> src/signal/s390x/sigsetjmp.s | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/signal/s390x/sigsetjmp.s b/src/signal/s390x/sigsetjmp.s
> index 72dfc25..41b1bd9 100644
> --- a/src/signal/s390x/sigsetjmp.s
> +++ b/src/signal/s390x/sigsetjmp.s
> @@ -6,7 +6,7 @@
> sigsetjmp:
> __sigsetjmp:
> ltgr %r3, %r3
> - bz ___setjmp
> + jz ___setjmp
>
> stg %r14, 18*8(%r2)
> stg %r6, 20*8(%r2)
The patch is probably okay but it needs a meaningful commit message.
The one you supplied merely restates the content of the diff in
English. What bug (crashing sigsetjmp, I think) is this fixing and why
is this change a/the right fix?
Rich
prev parent reply other threads:[~2016-11-28 19:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-27 18:18 Bobby Bingham
2016-11-28 19:31 ` Rich Felker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161128193100.GX1555@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).