From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/10755 Path: news.gmane.org!.POSTED!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH] s390: replace absolute branch with relative branch Date: Mon, 28 Nov 2016 14:31:00 -0500 Message-ID: <20161128193100.GX1555@brightrain.aerifal.cx> References: <20161127181810.19519-1-koorogi@koorogi.info> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1480361478 30671 195.159.176.226 (28 Nov 2016 19:31:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 28 Nov 2016 19:31:18 +0000 (UTC) User-Agent: Mutt/1.5.21 (2010-09-15) To: musl@lists.openwall.com Original-X-From: musl-return-10768-gllmg-musl=m.gmane.org@lists.openwall.com Mon Nov 28 20:31:14 2016 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1cBRdw-00077J-1W for gllmg-musl@m.gmane.org; Mon, 28 Nov 2016 20:31:12 +0100 Original-Received: (qmail 29979 invoked by uid 550); 28 Nov 2016 19:31:14 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 29959 invoked from network); 28 Nov 2016 19:31:13 -0000 Content-Disposition: inline In-Reply-To: <20161127181810.19519-1-koorogi@koorogi.info> Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:10755 Archived-At: On Sun, Nov 27, 2016 at 12:18:10PM -0600, Bobby Bingham wrote: > --- > src/signal/s390x/sigsetjmp.s | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/signal/s390x/sigsetjmp.s b/src/signal/s390x/sigsetjmp.s > index 72dfc25..41b1bd9 100644 > --- a/src/signal/s390x/sigsetjmp.s > +++ b/src/signal/s390x/sigsetjmp.s > @@ -6,7 +6,7 @@ > sigsetjmp: > __sigsetjmp: > ltgr %r3, %r3 > - bz ___setjmp > + jz ___setjmp > > stg %r14, 18*8(%r2) > stg %r6, 20*8(%r2) The patch is probably okay but it needs a meaningful commit message. The one you supplied merely restates the content of the diff in English. What bug (crashing sigsetjmp, I think) is this fixing and why is this change a/the right fix? Rich