* [PATCH] s390: replace absolute branch with relative branch
@ 2016-11-27 18:18 Bobby Bingham
2016-11-28 19:31 ` Rich Felker
0 siblings, 1 reply; 2+ messages in thread
From: Bobby Bingham @ 2016-11-27 18:18 UTC (permalink / raw)
To: musl
---
src/signal/s390x/sigsetjmp.s | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/signal/s390x/sigsetjmp.s b/src/signal/s390x/sigsetjmp.s
index 72dfc25..41b1bd9 100644
--- a/src/signal/s390x/sigsetjmp.s
+++ b/src/signal/s390x/sigsetjmp.s
@@ -6,7 +6,7 @@
sigsetjmp:
__sigsetjmp:
ltgr %r3, %r3
- bz ___setjmp
+ jz ___setjmp
stg %r14, 18*8(%r2)
stg %r6, 20*8(%r2)
--
2.10.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] s390: replace absolute branch with relative branch
2016-11-27 18:18 [PATCH] s390: replace absolute branch with relative branch Bobby Bingham
@ 2016-11-28 19:31 ` Rich Felker
0 siblings, 0 replies; 2+ messages in thread
From: Rich Felker @ 2016-11-28 19:31 UTC (permalink / raw)
To: musl
On Sun, Nov 27, 2016 at 12:18:10PM -0600, Bobby Bingham wrote:
> ---
> src/signal/s390x/sigsetjmp.s | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/signal/s390x/sigsetjmp.s b/src/signal/s390x/sigsetjmp.s
> index 72dfc25..41b1bd9 100644
> --- a/src/signal/s390x/sigsetjmp.s
> +++ b/src/signal/s390x/sigsetjmp.s
> @@ -6,7 +6,7 @@
> sigsetjmp:
> __sigsetjmp:
> ltgr %r3, %r3
> - bz ___setjmp
> + jz ___setjmp
>
> stg %r14, 18*8(%r2)
> stg %r6, 20*8(%r2)
The patch is probably okay but it needs a meaningful commit message.
The one you supplied merely restates the content of the diff in
English. What bug (crashing sigsetjmp, I think) is this fixing and why
is this change a/the right fix?
Rich
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-11-28 19:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-27 18:18 [PATCH] s390: replace absolute branch with relative branch Bobby Bingham
2016-11-28 19:31 ` Rich Felker
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).