mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: [PATCH] features.h: define __inline to empty for pre-c99 non-gcc compilers
Date: Fri, 16 Dec 2016 23:12:26 -0500	[thread overview]
Message-ID: <20161217041226.GF1555@brightrain.aerifal.cx> (raw)
In-Reply-To: <20161212200126.GA27916@alpha.fifth.space>

On Mon, Dec 12, 2016 at 09:01:26PM +0100, Quentin Rameau wrote:
> ---
> 
> After what we have discussed on IRC, I'm posting this one here so you
> have it at hand!
> 
> ---
>  include/features.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/include/features.h b/include/features.h
> index 3cc3e57..f4d651e 100644
> --- a/include/features.h
> +++ b/include/features.h
> @@ -24,6 +24,8 @@
>  
>  #if __STDC_VERSION__ >= 199901L || defined(__cplusplus)
>  #define __inline inline
> +#elif !defined(__GNUC__)
> +#define __inline
>  #endif
>  
>  #if __STDC_VERSION__ >= 201112L
> -- 
> 2.10.2

Thanks. The patch is fine, but the commit message should describe the
purpose/effect rather than paraphrasing the content of the patch in
English. I'll change it to:

"in public headers, don't assume pre-C99 compilers have __inline keyword"

Rich


      reply	other threads:[~2016-12-17  4:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-12 20:01 Quentin Rameau
2016-12-17  4:12 ` Rich Felker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161217041226.GF1555@brightrain.aerifal.cx \
    --to=dalias@libc.org \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).