* [PATCH] features.h: define __inline to empty for pre-c99 non-gcc compilers
@ 2016-12-12 20:01 Quentin Rameau
2016-12-17 4:12 ` Rich Felker
0 siblings, 1 reply; 2+ messages in thread
From: Quentin Rameau @ 2016-12-12 20:01 UTC (permalink / raw)
To: musl
---
After what we have discussed on IRC, I'm posting this one here so you
have it at hand!
---
include/features.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/features.h b/include/features.h
index 3cc3e57..f4d651e 100644
--- a/include/features.h
+++ b/include/features.h
@@ -24,6 +24,8 @@
#if __STDC_VERSION__ >= 199901L || defined(__cplusplus)
#define __inline inline
+#elif !defined(__GNUC__)
+#define __inline
#endif
#if __STDC_VERSION__ >= 201112L
--
2.10.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] features.h: define __inline to empty for pre-c99 non-gcc compilers
2016-12-12 20:01 [PATCH] features.h: define __inline to empty for pre-c99 non-gcc compilers Quentin Rameau
@ 2016-12-17 4:12 ` Rich Felker
0 siblings, 0 replies; 2+ messages in thread
From: Rich Felker @ 2016-12-17 4:12 UTC (permalink / raw)
To: musl
On Mon, Dec 12, 2016 at 09:01:26PM +0100, Quentin Rameau wrote:
> ---
>
> After what we have discussed on IRC, I'm posting this one here so you
> have it at hand!
>
> ---
> include/features.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/features.h b/include/features.h
> index 3cc3e57..f4d651e 100644
> --- a/include/features.h
> +++ b/include/features.h
> @@ -24,6 +24,8 @@
>
> #if __STDC_VERSION__ >= 199901L || defined(__cplusplus)
> #define __inline inline
> +#elif !defined(__GNUC__)
> +#define __inline
> #endif
>
> #if __STDC_VERSION__ >= 201112L
> --
> 2.10.2
Thanks. The patch is fine, but the commit message should describe the
purpose/effect rather than paraphrasing the content of the patch in
English. I'll change it to:
"in public headers, don't assume pre-C99 compilers have __inline keyword"
Rich
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-12-17 4:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-12 20:01 [PATCH] features.h: define __inline to empty for pre-c99 non-gcc compilers Quentin Rameau
2016-12-17 4:12 ` Rich Felker
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).