From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/10808 Path: news.gmane.org!.POSTED!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH] features.h: define __inline to empty for pre-c99 non-gcc compilers Date: Fri, 16 Dec 2016 23:12:26 -0500 Message-ID: <20161217041226.GF1555@brightrain.aerifal.cx> References: <20161212200126.GA27916@alpha.fifth.space> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1481947965 12341 195.159.176.226 (17 Dec 2016 04:12:45 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 17 Dec 2016 04:12:45 +0000 (UTC) User-Agent: Mutt/1.5.21 (2010-09-15) To: musl@lists.openwall.com Original-X-From: musl-return-10821-gllmg-musl=m.gmane.org@lists.openwall.com Sat Dec 17 05:12:41 2016 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1cI6MO-00022T-JX for gllmg-musl@m.gmane.org; Sat, 17 Dec 2016 05:12:36 +0100 Original-Received: (qmail 32253 invoked by uid 550); 17 Dec 2016 04:12:39 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 32235 invoked from network); 17 Dec 2016 04:12:38 -0000 Content-Disposition: inline In-Reply-To: <20161212200126.GA27916@alpha.fifth.space> Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:10808 Archived-At: On Mon, Dec 12, 2016 at 09:01:26PM +0100, Quentin Rameau wrote: > --- > > After what we have discussed on IRC, I'm posting this one here so you > have it at hand! > > --- > include/features.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/features.h b/include/features.h > index 3cc3e57..f4d651e 100644 > --- a/include/features.h > +++ b/include/features.h > @@ -24,6 +24,8 @@ > > #if __STDC_VERSION__ >= 199901L || defined(__cplusplus) > #define __inline inline > +#elif !defined(__GNUC__) > +#define __inline > #endif > > #if __STDC_VERSION__ >= 201112L > -- > 2.10.2 Thanks. The patch is fine, but the commit message should describe the purpose/effect rather than paraphrasing the content of the patch in English. I'll change it to: "in public headers, don't assume pre-C99 compilers have __inline keyword" Rich