From: u-uy74@aetey.se
To: musl@lists.openwall.com
Subject: Re: [PATCH] use lookup table for malloc bin index instead of float conversion
Date: Sat, 17 Dec 2016 08:36:00 +0100 [thread overview]
Message-ID: <20161217073600.GZ18078@example.net> (raw)
In-Reply-To: <20161217055058.GG1555@brightrain.aerifal.cx>
On Sat, Dec 17, 2016 at 12:50:58AM -0500, Rich Felker wrote:
> On Sun, Nov 27, 2016 at 03:15:41PM +0100, Szabolcs Nagy wrote:
> > +static const unsigned char bin_tab[64] = {
> > + 0, 0, 0, 0,32,33,34,35,36,36,37,37,38,38,39,39,
> > + 40,40,40,40,41,41,41,41,42,42,42,42,43,43,43,43,
> > + 44,44,44,44,44,44,44,44,45,45,45,45,45,45,45,45,
> > + 46,46,46,46,46,46,46,46,47,47,47,47,47,47,47,47,
> > +};
> > +
> > static int bin_index(size_t x)
> > {
> > x = x / SIZE_ALIGN - 1;
> > if (x <= 32) return x;
> > + if (x < 512) return bin_tab[x/8];
> > if (x > 0x1c00) return 63;
> > - return ((union { float v; uint32_t r; }){(int)x}.r>>21) - 496;
> > + return bin_tab[x/128] + 16;
> > }
> >
> > static int bin_index_up(size_t x)
> > {
> > x = x / SIZE_ALIGN - 1;
> > if (x <= 32) return x;
> > - return ((union { float v; uint32_t r; }){(int)x}.r+0x1fffff>>21) - 496;
> > + x--;
> > + if (x < 512) return bin_tab[x/8] + 1;
> > + return bin_tab[x/128] + 17;
> > }
> >
> > #if 0
> > --
> > 2.10.2
> Looks good mostly, but wouldn't it be better to drop the 4 unused
> entries from the table and add -4's to the indices?
Wouldn't this enlarge the code more than reduce the data?
Rune
next prev parent reply other threads:[~2016-12-17 7:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-27 14:15 Szabolcs Nagy
2016-12-17 5:50 ` Rich Felker
2016-12-17 7:36 ` u-uy74 [this message]
2016-12-17 14:03 ` [PATCH v2] " Szabolcs Nagy
2016-12-17 14:30 ` u-uy74
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161217073600.GZ18078@example.net \
--to=u-uy74@aetey.se \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).