PowerPC bits/user.h defining struct pt_regs

PowerPC bits/user.h defining struct pt_regs

[A. Wilcox]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

While trying to compile packages on PowerPC that use the ptrace kernel
interface - including gdb, psmisc, strace, systemtap, and other
packages - we are always receiving this error:

make[1]: Leaving directory
'/usr/src/sys-process/psmisc-22.21-r3/work/psmisc-22.21'
cd .. && make  am--refresh
cd .. && make  am--refresh
gcc -DHAVE_CONFIG_H -I. -I..    -Wall
- -DLOCALEDIR=\"/usr/share/locale\"   -DPPC    -O2 -mlong-double-64
- -ggdb -mcpu=G3 -fno-omit-frame-pointer -c -o peekfd.o peekfd.c
In file included from /usr/include/sys/user.h:11:0,
                 from peekfd.c:33:
/usr/include/bits/user.h:1:8: error: redefinition of 'struct pt_regs'
 struct pt_regs {
        ^
In file included from peekfd.c:30:0:
/usr/include/asm/ptrace.h:31:8: note: originally defined here
 struct pt_regs {
        ^

Removing the struct definition from bits/user.h fixes this error, but
I'm not entirely sure when pt_regs should be visible.

Any help solving this issue, especially before 1.1.16 is cut, would be
greatly helpful in getting a viable PowerPC environment for user
enjoyment. :)

Thanks so much and happy holiday,

- --arw

- -- 
A. Wilcox (awilfox)
Project Lead, Adélie Linux
http://adelielinux.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJYZgcJAAoJEMspy1GSK50UuiAQAJ1nrhPxgw3lg1HYMTnUXcSq
YiEzpcRLxJfZhc3lel9ES1ZfBbCdlKEcpAi81sPhpp3sA0OHjnrpGDS/5F7Ockog
Im+dNSh2QkSE2xQXxoMirIAjePmzBRv/H614QNT63XJhksujVtBiAhfgd4Ceh8gy
NO/+Hena/Pxm3eEfL4RMscYSfd7tlmJ0r0JCTo8oVQZNGf0cj/9R7kxMwfPgHauY
c+CcPZbpXYTNJZB9MMdZuEFImrqv7EjJbYhRr4xqorcgDskYuR338V+XGhPG+RBJ
AlwwrVT2dta8n0JmxYYSJzU52h+rUbIBtx6W2XgkmDqGBiWNynQ/03PRqLZCJBNh
5c/O3tB4eJKpzFsZKpwEPfycyxS21QJh5TG01mU2t1NO0amFp+8xI+vtv62Vy/as
jvCKuuamqJWayEbThHK4S+0T0PkLWhb1IOBIbScxBPqxhzzMHMQffsp8pAI+EUXO
bpHABL9hitMLi/goSl2fXNYebm7XkToywHRlTXHp4B5qeTiLYkd+0OT68tL8GcQn
2qy0Zs66O2msZJKof3+3M9VSRAP+KIx3cBjJR7tscax6K5rrilZmluMgDgTS7mdj
EQ7RWyqm9UO34OeXXhnftwFM+PPpvpzi2bESdt8f7TIwYFsEKPSLxGUBDSwJJ06O
EitC8wcaOi/BjD5y+YFI
=xrDa
-----END PGP SIGNATURE-----

Re: PowerPC bits/user.h defining struct pt_regs

[Rich Felker]

On Fri, Dec 30, 2016 at 01:04:45AM -0600, A. Wilcox wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA256
> 
> While trying to compile packages on PowerPC that use the ptrace kernel
> interface - including gdb, psmisc, strace, systemtap, and other
> packages - we are always receiving this error:
> 
> make[1]: Leaving directory
> '/usr/src/sys-process/psmisc-22.21-r3/work/psmisc-22.21'
> cd .. && make  am--refresh
> cd .. && make  am--refresh
> gcc -DHAVE_CONFIG_H -I. -I..    -Wall
> - -DLOCALEDIR=\"/usr/share/locale\"   -DPPC    -O2 -mlong-double-64
> - -ggdb -mcpu=G3 -fno-omit-frame-pointer -c -o peekfd.o peekfd.c
> In file included from /usr/include/sys/user.h:11:0,
>                  from peekfd.c:33:
> /usr/include/bits/user.h:1:8: error: redefinition of 'struct pt_regs'
>  struct pt_regs {
>         ^
> In file included from peekfd.c:30:0:
> /usr/include/asm/ptrace.h:31:8: note: originally defined here
>  struct pt_regs {
>         ^
> 
> Removing the struct definition from bits/user.h fixes this error, but
> I'm not entirely sure when pt_regs should be visible.

This was discussed before but I don't remember the outcome. user.h
needs to provide struct pt_regs on powerpc, because struct user
includes members with that type.

It's possible that the right solution will end up being removal of
user.h from musl and providing it in a separate package that depends
on kernel headers, at least for some archs.

> Any help solving this issue, especially before 1.1.16 is cut, would be
> greatly helpful in getting a viable PowerPC environment for user
> enjoyment. :)

I don't think it's a problem that has a short-term solution. :(

Rich