From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/10908 Path: news.gmane.org!.POSTED!not-for-mail From: Newsgroups: gmane.linux.lib.musl.general Subject: RE: bug in =?UTF-8?Q?getopt=5Flong=28=29?= Date: Sat, 07 Jan 2017 09:31:47 -0700 Message-ID: <20170107093147.dc30d64f61e5ec441c34ffd4f788e58e.a683212f25.wbe@email15.godaddy.com> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=_976365c847d775033ef7e2115518f263" X-Trace: blaine.gmane.org 1483806724 10166 195.159.176.226 (7 Jan 2017 16:32:04 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 7 Jan 2017 16:32:04 +0000 (UTC) User-Agent: Workspace Webmail 6.5.9 To: musl@lists.openwall.com Original-X-From: musl-return-10921-gllmg-musl=m.gmane.org@lists.openwall.com Sat Jan 07 17:32:00 2017 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1cPtuR-00021W-QJ for gllmg-musl@m.gmane.org; Sat, 07 Jan 2017 17:31:59 +0100 Original-Received: (qmail 32717 invoked by uid 550); 7 Jan 2017 16:32:02 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 32692 invoked from network); 7 Jan 2017 16:32:01 -0000 X-SID: VUXp1u0010CdqqM01 X-Originating-IP: 71.206.170.124 Xref: news.gmane.org gmane.linux.lib.musl.general:10908 Archived-At: --=_976365c847d775033ef7e2115518f263 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" =0A> =0A> =0A> -------- Original Message --------=0A> Subject: RE: [musl] b= ug in getopt_long()=0A> From: =0A> Date: Sat, Januar= y 07, 2017 8:13 am=0A> To: musl@lists.openwall.com=0A> =0A> =0A> > =0A> > = =0A> > -------- Original Message --------=0A> > Subject: [musl] bug in geto= pt_long()=0A> > From: "Anthony G. Basile" =0A> > Dat= e: Thu, January 05, 2017 9:00 am=0A> > To: musl@lists.openwall.com=0A> > = =0A> > Hi,=0A> > =0A> > We hit a bug in Gentoo with getopt_long(). It appea= rs the alpine people=0A> > hit it too http://bugs.alpinelinux.org/issues/48= 02. The problem was=0A> > encountered in open-iscsi but I got some reduced = code which I've=0A> > attached. If you build and run that code as `./test -= -portal=0A> > 10.144.0.14 --discover` then you get=0A> > =0A> > p=0A> > D= =0A> > unrecognized character 'D'=0A> > =0A> > On a glibc system, you don't= get the "unrecognized character 'D'" which=0A> > is what we'd expect. Rich= suggested a patch to musl which looked like=0A> > it might work, but it di= dn't. I didn't investigate further. I'm just=0A> > reporting it first to se= e if others know what's up.=0A> >=0A> =0A> The attached patch should work, = I believe; tested with both of the=0A> following:=0A> =0A> ./a.out --portal= 10.144.0.14 --discover=0A> ./a.out --portal 10.144.0.14 --discover -- foo = bar=0A=0ABehavior after my original patch deviated from glibc in the follow= ing=0Acase:=0A=0A./a.out -a -b -c -d -e --discover=0A=0AThe attached update= d patch should do the trick for all three cases.=0A=0Amidipix=0A=0A> =0A> m= idipix=0A> =0A> =0A> > =0A> > -- =0A> > Anthony G. Basile, Ph.D.=0A> > Gen= too Linux Developer [Hardened]=0A> > E-Mail : basile@freeharbor.net=0A> > G= nuPG FP : 1FED FAD9 D82C 52A5 3BAB DC79 9384 FA6E F52D 4BBA=0A> > GnuPG ID = : F52D4BBA=0A> >=0A=0A --=_976365c847d775033ef7e2115518f263 Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name="getopt_long_v2.patch"; Content-Disposition: attachment; filename="getopt_long_v2.patch"; RnJvbSBmMmFhZWFkOWE2ZjU1OTVmMjA3MjhlNTU4MjU3NGU1MGFkYWM5MzA4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBtaWRpcGl4IDx3cml0ZW9uY2VAbWlkaXBpeC5vcmc+CkRhdGU6 IFNhdCwgNyBKYW4gMjAxNyAwOTo0MzoxMCAtMDUwMApTdWJqZWN0OiBbUEFUQ0hdIGdldG9wdF9s b25nKCk6IHJlY29yZCBzdWNjZXNzZnVsIGNvbXBsZXRlZCBwYXJzaW5nIG9mIGFsbAogYXJndW1l bnRzLgoKLS0tCiBzcmMvbWlzYy9nZXRvcHRfbG9uZy5jIHwgNyArKysrKysrCiAxIGZpbGUgY2hh bmdlZCwgNyBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvc3JjL21pc2MvZ2V0b3B0X2xvbmcu YyBiL3NyYy9taXNjL2dldG9wdF9sb25nLmMKaW5kZXggNTY4YWU3Yi4uZDIwZDRmMyAxMDA2NDQK LS0tIGEvc3JjL21pc2MvZ2V0b3B0X2xvbmcuYworKysgYi9zcmMvbWlzYy9nZXRvcHRfbG9uZy5j CkBAIC01LDYgKzUsNyBAQAogI2luY2x1ZGUgPHN0cmluZy5oPgogCiBleHRlcm4gaW50IF9fb3B0 cG9zLCBfX29wdHJlc2V0Oworc3RhdGljIGludCBfX2dldG9wdF9lcnIgPSAwOwogCiBzdGF0aWMg dm9pZCBwZXJtdXRlKGNoYXIgKmNvbnN0ICphcmd2LCBpbnQgZGVzdCwgaW50IHNyYykKIHsKQEAg LTI2LDggKzI3LDEzIEBAIHN0YXRpYyBpbnQgX19nZXRvcHRfbG9uZyhpbnQgYXJnYywgY2hhciAq Y29uc3QgKmFyZ3YsIGNvbnN0IGNoYXIgKm9wdHN0cmluZywgY29uCiAJaWYgKCFvcHRpbmQgfHwg X19vcHRyZXNldCkgewogCQlfX29wdHJlc2V0ID0gMDsKIAkJX19vcHRwb3MgPSAwOworCQlfX2dl dG9wdF9lcnIgPSAwOwogCQlvcHRpbmQgPSAxOwogCX0KKwlpZiAob3B0aW5kID09IGFyZ2MgJiYg IV9fZ2V0b3B0X2VycikgeworCQlvcHRvcHQgPSAwOworCQlyZXR1cm4gLTE7CisJfQogCWlmIChv cHRpbmQgPj0gYXJnYyB8fCAhYXJndltvcHRpbmRdKSByZXR1cm4gLTE7CiAJc2tpcHBlZCA9IG9w dGluZDsKIAlpZiAob3B0c3RyaW5nWzBdICE9ICcrJyAmJiBvcHRzdHJpbmdbMF0gIT0gJy0nKSB7 CkBAIC00Niw2ICs1Miw3IEBAIHN0YXRpYyBpbnQgX19nZXRvcHRfbG9uZyhpbnQgYXJnYywgY2hh ciAqY29uc3QgKmFyZ3YsIGNvbnN0IGNoYXIgKm9wdHN0cmluZywgY29uCiAJCQlwZXJtdXRlKGFy Z3YsIHNraXBwZWQsIG9wdGluZC0xKTsKIAkJb3B0aW5kID0gc2tpcHBlZCArIGNudDsKIAl9CisJ X19nZXRvcHRfZXJyIHw9ICgocmV0ID09ICc/JykgfHwgKHJldCA9PSAnOicpKTsKIAlyZXR1cm4g cmV0OwogfQogCi0tIAoyLjguMwoK --=_976365c847d775033ef7e2115518f263--