mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: [PATCH 2/2] Fix digit offset on resolv.conf attempts.
Date: Thu, 19 Jan 2017 22:50:19 -0500	[thread overview]
Message-ID: <20170120035019.GR1533@brightrain.aerifal.cx> (raw)
In-Reply-To: <20170119214748.12216-3-karl.bielefeldt@adtran.com>

On Thu, Jan 19, 2017 at 09:49:08PM +0000, KARL BIELEFELDT wrote:
> ---
>  src/network/resolvconf.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/network/resolvconf.c b/src/network/resolvconf.c
> index 2cf1f475..4c3e4c4b 100644
> --- a/src/network/resolvconf.c
> +++ b/src/network/resolvconf.c
> @@ -45,8 +45,8 @@ int __get_resolv_conf(struct resolvconf *conf, char *search, size_t search_sz)
>  				if (z != p) conf->ndots = x > 15 ? 15 : x;
>  			}
>  			p = strstr(line, "attempts:");
> -			if (p && isdigit(p[6])) {
> -				p += 6;
> +			if (p && isdigit(p[9])) {
> +				p += 9;
>  				unsigned long x = strtoul(p, &z, 10);
>  				if (z != p) conf->attempts = x > 10 ? 10 : x;
>  			}

This looks correct. Would you like to be credited as commit author? (I
usually ask for new first-time contributors before putting name/email
in permanent repo history.)

Rich


  reply	other threads:[~2017-01-20  3:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-19 21:48 Patches for DNS resolving KARL BIELEFELDT
2017-01-19 21:49 ` [PATCH 1/2] Fix name_from_dns_search to handle errors properly KARL BIELEFELDT
2017-01-19 23:11   ` Rich Felker
2017-01-20  0:13     ` KARL BIELEFELDT
2017-01-20  1:02       ` Rich Felker
2017-01-20 16:23         ` KARL BIELEFELDT
2017-01-19 21:49 ` [PATCH 2/2] Fix digit offset on resolv.conf attempts KARL BIELEFELDT
2017-01-20  3:50   ` Rich Felker [this message]
2017-01-20 16:22     ` KARL BIELEFELDT

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170120035019.GR1533@brightrain.aerifal.cx \
    --to=dalias@libc.org \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).