Re: musl s390x bug

[Rich Felker <dalias@libc.org>]

On Sun, Feb 05, 2017 at 09:45:53PM -0600, Bobby Bingham wrote:
> On Sun, Feb 05, 2017 at 01:08:36AM +0100, Shiz wrote:
> >
> > > Then I applied Shiz's patch to src/ldso/s390x/dlsym.s :
> > > http://txt.shiz.me/M2Y5NGI3Ym
> > >
> > > and I got a segfault when running gcc on Alpine s390x chroot (built using a cross-compiler).
> >
> > Note that I know absolutely nothing about S/390 assembly, and this was just an outline of
> > how such a file would look like from my very quick skimming of the S/390 ABI and assembly
> > manuals. :P Someone with more knowledge of S/390 stuff should take a proper look at it.
> >
> > - Shiz
> 
> Can you try the attached patch?

> >From c61422be9eb3b5a4867feca5b0caf0da9c1f1a98 Mon Sep 17 00:00:00 2001
> From: Bobby Bingham <koorogi@koorogi.info>
> Date: Sun, 5 Feb 2017 21:29:52 -0600
> Subject: [PATCH] s390x: implement dlsym
> 
> This was missed when writing the port initially.
> ---
>  src/ldso/s390x/dlsym.s | 6 ++++++
>  1 file changed, 6 insertions(+)
>  create mode 100644 src/ldso/s390x/dlsym.s
> 
> diff --git a/src/ldso/s390x/dlsym.s b/src/ldso/s390x/dlsym.s
> new file mode 100644
> index 00000000..2e9fa8fb
> --- /dev/null
> +++ b/src/ldso/s390x/dlsym.s
> @@ -0,0 +1,6 @@
> +	.global dlsym
> +	.hidden __dlsym
> +	.type   dlsym,@function
> +dlsym:
> +	lgr %r4, %r14
> +	jg __dlsym
> -- 
> 2.11.0
> 

Can anyone confirm whether this works? If so I'll commit it.

Rich