From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/11042 Path: news.gmane.org!.POSTED!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: musl s390x bug Date: Wed, 15 Feb 2017 14:57:00 -0500 Message-ID: <20170215195700.GK1520@brightrain.aerifal.cx> References: <43FE917A-48CB-4D0F-AD74-9B671B40F2CE@shiz.me> <20170206034553.GA19575@dora.lan> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1487188638 7345 195.159.176.226 (15 Feb 2017 19:57:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 15 Feb 2017 19:57:18 +0000 (UTC) User-Agent: Mutt/1.5.21 (2010-09-15) To: musl@lists.openwall.com Original-X-From: musl-return-11057-gllmg-musl=m.gmane.org@lists.openwall.com Wed Feb 15 20:57:13 2017 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1ce5hQ-0001Z1-IA for gllmg-musl@m.gmane.org; Wed, 15 Feb 2017 20:57:12 +0100 Original-Received: (qmail 23925 invoked by uid 550); 15 Feb 2017 19:57:15 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 23907 invoked from network); 15 Feb 2017 19:57:15 -0000 Content-Disposition: inline In-Reply-To: <20170206034553.GA19575@dora.lan> Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:11042 Archived-At: On Sun, Feb 05, 2017 at 09:45:53PM -0600, Bobby Bingham wrote: > On Sun, Feb 05, 2017 at 01:08:36AM +0100, Shiz wrote: > > > > > Then I applied Shiz's patch to src/ldso/s390x/dlsym.s : > > > http://txt.shiz.me/M2Y5NGI3Ym > > > > > > and I got a segfault when running gcc on Alpine s390x chroot (built using a cross-compiler). > > > > Note that I know absolutely nothing about S/390 assembly, and this was just an outline of > > how such a file would look like from my very quick skimming of the S/390 ABI and assembly > > manuals. :P Someone with more knowledge of S/390 stuff should take a proper look at it. > > > > - Shiz > > Can you try the attached patch? > >From c61422be9eb3b5a4867feca5b0caf0da9c1f1a98 Mon Sep 17 00:00:00 2001 > From: Bobby Bingham > Date: Sun, 5 Feb 2017 21:29:52 -0600 > Subject: [PATCH] s390x: implement dlsym > > This was missed when writing the port initially. > --- > src/ldso/s390x/dlsym.s | 6 ++++++ > 1 file changed, 6 insertions(+) > create mode 100644 src/ldso/s390x/dlsym.s > > diff --git a/src/ldso/s390x/dlsym.s b/src/ldso/s390x/dlsym.s > new file mode 100644 > index 00000000..2e9fa8fb > --- /dev/null > +++ b/src/ldso/s390x/dlsym.s > @@ -0,0 +1,6 @@ > + .global dlsym > + .hidden __dlsym > + .type dlsym,@function > +dlsym: > + lgr %r4, %r14 > + jg __dlsym > -- > 2.11.0 > Can anyone confirm whether this works? If so I'll commit it. Rich