mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Rich Felker <dalias@aerifal.cx>
To: musl@lists.openwall.com
Subject: Re: [PATCH] musl-gcc.spec: honour $LIBRARY_PATH / $LPATH
Date: Wed, 22 Feb 2017 16:11:58 -0500	[thread overview]
Message-ID: <20170222211158.GU1520@brightrain.aerifal.cx> (raw)
In-Reply-To: <1487797025-32177-1-git-send-email-minipli@googlemail.com>

On Wed, Feb 22, 2017 at 09:57:05PM +0100, Mathias Krause wrote:
> To support additional library search paths via $LIBRARY_PATH / $LPATH
> extend the link_libgcc variable instead of replacing it. The original
> one will contain the required "%D" to support this.
> 
> musl's library path is still the first in the list, so its object files
> will be found before other paths are taken into account.
> 
> Signed-off-by: Mathias Krause <minipli@googlemail.com>
> ---
>  tools/musl-gcc.specs.sh |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/musl-gcc.specs.sh b/tools/musl-gcc.specs.sh
> index 294e24f75503..819799a6d5a7 100644
> --- a/tools/musl-gcc.specs.sh
> +++ b/tools/musl-gcc.specs.sh
> @@ -10,8 +10,10 @@ cat <<EOF
>  *cc1:
>  %(cc1_cpu) -nostdinc -isystem $incdir -isystem include%s
>  
> +%rename link_libgcc old_link_libgcc
> +
>  *link_libgcc:
> --L$libdir -L .%s
> +-L$libdir %(old_link_libgcc)

I'm pretty sure this is wrong. What are you trying to achieve? The
whole point of musl-gcc is to _remove_ any existing library paths
since, if present, they will cause configure scripts to detect and
link to incompatible libraries (linked against glibc). The only
library path we want to preserve is the one to libgcc.

Rich


  reply	other threads:[~2017-02-22 21:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-22 20:57 Mathias Krause
2017-02-22 21:11 ` Rich Felker [this message]
2017-02-22 21:54   ` Mathias Krause
2017-02-22 22:14     ` Rich Felker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170222211158.GU1520@brightrain.aerifal.cx \
    --to=dalias@aerifal.cx \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).