From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/11105 Path: news.gmane.org!.POSTED!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH] fix lsearch and lfind to pass key as first arg to the compar callback Date: Sun, 5 Mar 2017 20:05:13 -0500 Message-ID: <20170306010513.GL1520@brightrain.aerifal.cx> References: <20170305220334.GH2082@port70.net> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1488762326 1553 195.159.176.226 (6 Mar 2017 01:05:26 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 6 Mar 2017 01:05:26 +0000 (UTC) User-Agent: Mutt/1.5.21 (2010-09-15) To: musl@lists.openwall.com Original-X-From: musl-return-11120-gllmg-musl=m.gmane.org@lists.openwall.com Mon Mar 06 02:05:22 2017 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1ckh5W-0008SA-EH for gllmg-musl@m.gmane.org; Mon, 06 Mar 2017 02:05:22 +0100 Original-Received: (qmail 21607 invoked by uid 550); 6 Mar 2017 01:05:26 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 21589 invoked from network); 6 Mar 2017 01:05:26 -0000 Content-Disposition: inline In-Reply-To: <20170305220334.GH2082@port70.net> Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:11105 Archived-At: On Sun, Mar 05, 2017 at 11:03:35PM +0100, Szabolcs Nagy wrote: > this is not a conformance issue as posix does not specify the > argument order, but the order is specified for bsearch and some > systems document the order for lsearch consistently (openbsd). > > since there were two indpendent reports of this issue it's better > to use the more widely expected argument order. > --- > > in both reported cases upstream got fixed, but i think it > is worth changing anyway. Thanks. Committed and pushed. Rich