From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/11120 Path: news.gmane.org!.POSTED!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general,gmane.linux.kernel,gmane.linux.kernel.api Subject: Re: Re: [PATCH resent] uapi libc compat: allow non-glibc to opt out of uapi definitions Date: Wed, 8 Mar 2017 11:25:07 -0500 Message-ID: <20170308162507.GY1520@brightrain.aerifal.cx> References: <20161111120820.GA435@nyan> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1488990391 5082 195.159.176.226 (8 Mar 2017 16:26:31 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 8 Mar 2017 16:26:31 +0000 (UTC) User-Agent: Mutt/1.5.21 (2010-09-15) Cc: linux-kernel@vger.kernel.org, "David S. Miller" , linux-api@vger.kernel.org, musl@lists.openwall.com To: Carlos O'Donell Original-X-From: musl-return-11135-gllmg-musl=m.gmane.org@lists.openwall.com Wed Mar 08 17:26:26 2017 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1clePx-0000kg-9j for gllmg-musl@m.gmane.org; Wed, 08 Mar 2017 17:26:25 +0100 Original-Received: (qmail 14088 invoked by uid 550); 8 Mar 2017 16:26:29 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 14064 invoked from network); 8 Mar 2017 16:26:29 -0000 Content-Disposition: inline In-Reply-To: Xref: news.gmane.org gmane.linux.lib.musl.general:11120 gmane.linux.kernel:2426485 gmane.linux.kernel.api:22413 Archived-At: On Wed, Mar 08, 2017 at 10:53:00AM -0500, Carlos O'Donell wrote: > On 11/11/2016 07:08 AM, Felix Janda wrote: > > Currently, libc-compat.h detects inclusion of specific glibc headers, > > and defines corresponding _UAPI_DEF_* macros, which in turn are used in > > uapi headers to prevent definition of conflicting structures/constants. > > There is no such detection for other c libraries, for them the > > _UAPI_DEF_* macros are always defined as 1, and so none of the possibly > > conflicting definitions are suppressed. > > > > This patch enables non-glibc c libraries to request the suppression of > > any specific interface by defining the corresponding _UAPI_DEF_* macro > > as 0. > > > > This patch together with the recent musl libc commit > > > > http://git.musl-libc.org/cgit/musl/commit/?id=04983f2272382af92eb8f8838964ff944fbb8258 > > Would it be possible to amend the musl patch to define the macros to 1. I don't follow. They're defined to 0 explicitly to tell the kernel headers not to define their own versions of these structs, etc. since they would clash. Defining to 1 would have the opposite meaning. Rich