From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: [PATCH] strptime fixes
Date: Tue, 21 Mar 2017 12:38:11 -0400 [thread overview]
Message-ID: <20170321163811.GB17319@brightrain.aerifal.cx> (raw)
In-Reply-To: <25C67107-1C11-4606-9171-051707D92278@gmail.com>
On Sat, Mar 18, 2017 at 05:10:28PM +0100, Julien Ramseier wrote:
> I found several bugs in strptime:
>
> 1. tm_yday is off by one with %j (tm_yday range is 0-365 while %j is 1-366).
> 2. string pointer is not incremented when processing %p format.
> 3. calling strptime(..., "%C", tm), where tm->tm_year != 0, will result in a
> wrong value stored in tm_year.
>
These all look fine, committing.
Rich
prev parent reply other threads:[~2017-03-21 16:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-18 16:10 Julien Ramseier
2017-03-21 16:38 ` Rich Felker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170321163811.GB17319@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).