From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/11175 Path: news.gmane.org!.POSTED!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH] strptime fixes Date: Tue, 21 Mar 2017 12:38:11 -0400 Message-ID: <20170321163811.GB17319@brightrain.aerifal.cx> References: <25C67107-1C11-4606-9171-051707D92278@gmail.com> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1490114308 19502 195.159.176.226 (21 Mar 2017 16:38:28 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 21 Mar 2017 16:38:28 +0000 (UTC) User-Agent: Mutt/1.5.21 (2010-09-15) To: musl@lists.openwall.com Original-X-From: musl-return-11190-gllmg-musl=m.gmane.org@lists.openwall.com Tue Mar 21 17:38:24 2017 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1cqMnc-0004CD-RC for gllmg-musl@m.gmane.org; Tue, 21 Mar 2017 17:38:20 +0100 Original-Received: (qmail 23924 invoked by uid 550); 21 Mar 2017 16:38:25 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 23906 invoked from network); 21 Mar 2017 16:38:25 -0000 Content-Disposition: inline In-Reply-To: <25C67107-1C11-4606-9171-051707D92278@gmail.com> Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:11175 Archived-At: On Sat, Mar 18, 2017 at 05:10:28PM +0100, Julien Ramseier wrote: > I found several bugs in strptime: > > 1. tm_yday is off by one with %j (tm_yday range is 0-365 while %j is 1-366). > 2. string pointer is not incremented when processing %p format. > 3. calling strptime(..., "%C", tm), where tm->tm_year != 0, will result in a > wrong value stored in tm_year. > These all look fine, committing. Rich