From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/11202 Path: news.gmane.org!.POSTED!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general,gmane.comp.lib.glibc.alpha Subject: Re: [PATCH] add support for POSIX_SPAWN_SETSID Date: Fri, 31 Mar 2017 12:01:56 -0400 Message-ID: <20170331160156.GL17319@brightrain.aerifal.cx> References: <20170331050243.4485-1-quae@daurnimator.com> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1490976134 25922 195.159.176.226 (31 Mar 2017 16:02:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 31 Mar 2017 16:02:14 +0000 (UTC) User-Agent: Mutt/1.5.21 (2010-09-15) Cc: libc-alpha@sourceware.org To: musl@lists.openwall.com Original-X-From: musl-return-11217-gllmg-musl=m.gmane.org@lists.openwall.com Fri Mar 31 18:02:09 2017 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1ctz02-0005x5-Kk for gllmg-musl@m.gmane.org; Fri, 31 Mar 2017 18:02:06 +0200 Original-Received: (qmail 29811 invoked by uid 550); 31 Mar 2017 16:02:09 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 29777 invoked from network); 31 Mar 2017 16:02:08 -0000 Content-Disposition: inline In-Reply-To: <20170331050243.4485-1-quae@daurnimator.com> Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:11202 gmane.comp.lib.glibc.alpha:70716 Archived-At: On Fri, Mar 31, 2017 at 04:02:43PM +1100, daurnimator wrote: > This patch adds support for the POSIX_SPAWN_SETSID flag. > > It was recently accepted by the Austin Group: > http://austingroupbugs.net/view.php?id=1044 > > --- > include/spawn.h | 1 + > src/process/posix_spawn.c | 4 ++++ > 2 files changed, 5 insertions(+) > > diff --git a/include/spawn.h b/include/spawn.h > index 29c799ee..7dee7cfa 100644 > --- a/include/spawn.h > +++ b/include/spawn.h > @@ -21,6 +21,7 @@ struct sched_param; > #define POSIX_SPAWN_SETSIGMASK 8 > #define POSIX_SPAWN_SETSCHEDPARAM 16 > #define POSIX_SPAWN_SETSCHEDULER 32 > +#define POSIX_SPAWN_SETSID 64 This overlaps with the glibc value for POSIX_SPAWN_USEVFORK; while we don't implement it, we also don't want to have mismatched constant ABI. I know this is asking a lot, but could you possibly submit a glibc patch too so the intended value (128 I guess?) is established on their side too, or (yay if you can!) poke somebody else to do it? In the past I've tried to just get them to casually agree to assigning values for things like this before they implement them, but I haven't had much luck. Cc'ing libc-alpha too. Rich