mailing list of musl libc
 help / color / mirror / code / Atom feed
From: "dalias@libc.org" <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: [MUSL] microMIPS32R2 O32 port
Date: Thu, 6 Apr 2017 12:18:04 -0400	[thread overview]
Message-ID: <20170406161804.GM17319@brightrain.aerifal.cx> (raw)
In-Reply-To: <BD7773622145634B952E5B54ACA8E349DAE2BD60@PUMAIL01.pu.imgtec.org>

On Wed, Apr 05, 2017 at 06:33:01AM +0000, Jaydeep Patil wrote:
> Hi Rich,
> 
> Please refer to
> https://github.com/JaydeepIMG/musl-1/tree/micromips32r2_v1 for
> microMIPS32R2 O32 port. I have also attached the patch
> (microMIPS32R2_v1_port.patch) for your reference.
> Could you please review it?

Some important first questions:

Is micromips an ISA level or a new ISA? This is the same question as
last time with MIPS r6 and the answer was not obvious and seemingly
intentionally obscured by the official documentation. The answer is
important to how we approach supporting it. Do cpus that support
micromips also support plain mips? Is it like thumb where arm/thumb
code can be linked together and call into one another in the same
process, or are they different modes?

Once we answer those questions, can you provide justifications for the
proposed changes? From your patches it looks like branch delay slots
don't exist in micromips mode. There may be other differences too; I
didn't read it in detail. Rather than add a bunch of ifdefs I'd rather
figure out how we can generalize the code so that it's compatible with
both. This is what was done on arm when making it so the asm can be
compiled as thumb2.

Rich


  reply	other threads:[~2017-04-06 16:18 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-05  6:33 Jaydeep Patil
2017-04-06 16:18 ` dalias [this message]
2017-04-07  6:47   ` Jaydeep Patil
2017-04-07 14:19     ` Rich Felker
2017-04-12 11:54       ` Jaydeep Patil
2017-04-12 19:25         ` Szabolcs Nagy
2017-04-12 20:27           ` Rich Felker
2017-04-12 21:47             ` Andre McCurdy
2017-04-13  4:29               ` Jaydeep Patil
2017-04-13  9:00                 ` Szabolcs Nagy
2017-04-13 10:37                   ` Jaydeep Patil
2017-04-21  9:40                     ` Jaydeep Patil
2017-04-21 13:33                     ` Rich Felker
2017-04-24  5:30                       ` Jaydeep Patil
2017-04-24 13:48                         ` Rich Felker
2017-04-25  4:45                           ` Jaydeep Patil
2017-04-25 16:52                             ` Rich Felker
2017-04-26  7:14                               ` Jaydeep Patil
2017-05-11  3:25                                 ` Jaydeep Patil
2017-05-17  8:28                                   ` Jaydeep Patil
2017-05-26  3:46                                   ` Jaydeep Patil
2017-05-28  2:00                                     ` Rich Felker
2017-05-31 13:11                                       ` Rich Felker
2017-06-01  4:21                                         ` Jaydeep Patil
2017-04-21 13:26                 ` Rich Felker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170406161804.GM17319@brightrain.aerifal.cx \
    --to=dalias@libc.org \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).