From: Szabolcs Nagy <nsz@port70.net>
To: musl@lists.openwall.com
Subject: Re: byteswap.h
Date: Sat, 8 Apr 2017 16:57:04 +0200 [thread overview]
Message-ID: <20170408145703.GB2082@port70.net> (raw)
In-Reply-To: <20170407180742.GB8704@wirbelwind>
* Joakim Sindholt <opensource@zhasha.com> [2017-04-07 20:07:42 +0200]:
> On Fri, Apr 07, 2017 at 07:53:09PM +0200, fab10 wrote:
> > I had a look at byteswap.h and it seems to me that the code is not very
> > efficient. Every function in this header could be translated in a single
> > assembly instruction with the gcc intrinsics:
> >
> > __builtin_bswap16
> > __builtin_bswap32
> > __builtin_bswap64
> >
> > Is there a reason to not use these gcc intrinsics?
> >
> > Bye
> >
>
> While musl does employ GNU C features in quite a few places it's just
> plain unnecessary here.
>
rarely in public headers though which have to
be portable to all c source parser tools.
builtins would need to be conditional on __GNUC__
and we still need the portable code as a fallback
which is harder to maintain and test
> https://godbolt.org/g/eLZWwI
>
> When optimized those functions yield a single bswap instruction anyway,
> because GCC is smart enough to deduce this.
prev parent reply other threads:[~2017-04-08 14:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-07 17:53 byteswap.h fab10
2017-04-07 17:55 ` byteswap.h Jon Chesterfield
2017-04-07 18:01 ` byteswap.h Rich Felker
2017-04-07 18:07 ` byteswap.h Joakim Sindholt
2017-04-08 14:57 ` Szabolcs Nagy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170408145703.GB2082@port70.net \
--to=nsz@port70.net \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).