From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/11241 Path: news.gmane.org!.POSTED!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: superfluous space char in marco Date: Mon, 17 Apr 2017 10:48:41 -0400 Message-ID: <20170417144841.GZ17319@brightrain.aerifal.cx> References: Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1492440538 25293 195.159.176.226 (17 Apr 2017 14:48:58 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 17 Apr 2017 14:48:58 +0000 (UTC) User-Agent: Mutt/1.5.21 (2010-09-15) Cc: musl@lists.openwall.com To: Syrone Wong Original-X-From: musl-return-11256-gllmg-musl=m.gmane.org@lists.openwall.com Mon Apr 17 16:48:54 2017 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1d07xV-0006Sc-0B for gllmg-musl@m.gmane.org; Mon, 17 Apr 2017 16:48:53 +0200 Original-Received: (qmail 22342 invoked by uid 550); 17 Apr 2017 14:48:55 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 22320 invoked from network); 17 Apr 2017 14:48:54 -0000 Content-Disposition: inline In-Reply-To: Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:11241 Archived-At: On Sun, Apr 16, 2017 at 03:58:11PM +0800, Syrone Wong wrote: > For include/net/if.h, we define it as > > #define IFF_VOLATILE (IFF_LOOPBACK|IFF_POINTOPOINT|IFF_BROADCAST| \ > IFF_ECHO|IFF_MASTER|IFF_SLAVE|IFF_RUNNING|IFF_LOWER_UP|IFF_DORMANT) > > while iproute2 4.10.0 define it as > > #define IFF_VOLATILE (IFF_LOOPBACK|IFF_POINTOPOINT|IFF_BROADCAST|IFF_ECHO|\ > IFF_MASTER|IFF_SLAVE|IFF_RUNNING|IFF_LOWER_UP|IFF_DORMANT) > > in include/linux/if.h. The only difference is the space char after > IFF_BROADCAST. Do the other iproute2 include/linux/* headers actually work now? My experience building it in the past has been that you have to rm -rf that directory to get it to build at all since it contained outdated and clashing versions of those headers. Maybe something has changed in recent versions. > This causes the redefinition of IFF_VOLATILE. > > Warning when compiling iproute2 4.10.0: > > In file included from ../include/linux/if_tunnel.h:5:0, > from iptunnel.c:24: > .../include/linux/if.h:130:0: warning: "IFF_VOLATILE" redefined > #define IFF_VOLATILE (IFF_LOOPBACK|IFF_POINTOPOINT|IFF_BROADCAST|IFF_ECHO|\ > > In file included from iptunnel.c:21:0: > /home/wong/github/lede-1/staging_dir/toolchain-arm_cortex-a9+vfpv3_gcc-6.3.0_musl_eabi/include/net/if.h:48:0: > note: this is the location of the previous definition > #define IFF_VOLATILE (IFF_LOOPBACK|IFF_POINTOPOINT|IFF_BROADCAST| \ This is odd and looks like a gcc bug. Preprocessor macros definitions are sequences of PP tokens, not literal code strings, meaning that whitespace is irrelevant as long as the resulting sequence of PP tokens remains the same; it's a matching definition not a redefinition. Anyone else have thoughts on what's going on? Rich