mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: superfluous space char in marco
Date: Mon, 17 Apr 2017 13:35:46 -0400	[thread overview]
Message-ID: <20170417173546.GB17319@brightrain.aerifal.cx> (raw)
In-Reply-To: <20170417172918.GL2082@port70.net>

On Mon, Apr 17, 2017 at 07:29:19PM +0200, Szabolcs Nagy wrote:
> * Rich Felker <dalias@libc.org> [2017-04-17 13:02:08 -0400]:
> > On Mon, Apr 17, 2017 at 06:28:58PM +0300, Alexander Monakov wrote:
> > > On Mon, 17 Apr 2017, Rich Felker wrote:
> > > > This is odd and looks like a gcc bug. Preprocessor macros definitions
> > > > are sequences of PP tokens, not literal code strings, meaning that
> > > > whitespace is irrelevant as long as the resulting sequence of PP
> > > > tokens remains the same; it's a matching definition not a
> > > > redefinition.
> > > 
> > > No, according to C11 6.10.3 p1 presence of whitespace is significant (its
> > > contents are not), and 6.10.3.5 example 6 corroborates that.  GCC, Clang,
> > > ICC and MSVC on Godbolt all agree with that.
> > 
> > Thanks for clarifying! I had forgotten this detail. It probably makes
> > sense to change it, then.
> 
> linux uapi header has whitespace befor IFF_MASTER
> if we match the definition with something i think
> it should be the linux header not iproute2

Yes, the official Linux one, not iproute2's fork, is what we should
match, if anything.

Rich


      reply	other threads:[~2017-04-17 17:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-16  7:58 Syrone Wong
2017-04-17 14:48 ` Rich Felker
2017-04-17 15:28   ` Alexander Monakov
2017-04-17 17:02     ` Rich Felker
2017-04-17 17:29       ` Szabolcs Nagy
2017-04-17 17:35         ` Rich Felker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170417173546.GB17319@brightrain.aerifal.cx \
    --to=dalias@libc.org \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).