From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/11245 Path: news.gmane.org!.POSTED!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: superfluous space char in marco Date: Mon, 17 Apr 2017 13:35:46 -0400 Message-ID: <20170417173546.GB17319@brightrain.aerifal.cx> References: <20170417144841.GZ17319@brightrain.aerifal.cx> <20170417170208.GA17319@brightrain.aerifal.cx> <20170417172918.GL2082@port70.net> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1492450559 10845 195.159.176.226 (17 Apr 2017 17:35:59 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 17 Apr 2017 17:35:59 +0000 (UTC) User-Agent: Mutt/1.5.21 (2010-09-15) To: musl@lists.openwall.com Original-X-From: musl-return-11260-gllmg-musl=m.gmane.org@lists.openwall.com Mon Apr 17 19:35:55 2017 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1d0AZ8-0002jR-VS for gllmg-musl@m.gmane.org; Mon, 17 Apr 2017 19:35:55 +0200 Original-Received: (qmail 17851 invoked by uid 550); 17 Apr 2017 17:35:59 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 17828 invoked from network); 17 Apr 2017 17:35:58 -0000 Content-Disposition: inline In-Reply-To: <20170417172918.GL2082@port70.net> Original-Sender: Rich Felker Xref: news.gmane.org gmane.linux.lib.musl.general:11245 Archived-At: On Mon, Apr 17, 2017 at 07:29:19PM +0200, Szabolcs Nagy wrote: > * Rich Felker [2017-04-17 13:02:08 -0400]: > > On Mon, Apr 17, 2017 at 06:28:58PM +0300, Alexander Monakov wrote: > > > On Mon, 17 Apr 2017, Rich Felker wrote: > > > > This is odd and looks like a gcc bug. Preprocessor macros definitions > > > > are sequences of PP tokens, not literal code strings, meaning that > > > > whitespace is irrelevant as long as the resulting sequence of PP > > > > tokens remains the same; it's a matching definition not a > > > > redefinition. > > > > > > No, according to C11 6.10.3 p1 presence of whitespace is significant (its > > > contents are not), and 6.10.3.5 example 6 corroborates that. GCC, Clang, > > > ICC and MSVC on Godbolt all agree with that. > > > > Thanks for clarifying! I had forgotten this detail. It probably makes > > sense to change it, then. > > linux uapi header has whitespace befor IFF_MASTER > if we match the definition with something i think > it should be the linux header not iproute2 Yes, the official Linux one, not iproute2's fork, is what we should match, if anything. Rich